Skip to content

Commit 11dc363

Browse files
committed
Chore: Support non-HNS buckets in moveObjectAtomic
Removed HNS-only restriction comments. Restructured tests for non-HNS coverage.
1 parent 5be36a7 commit 11dc363

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

storage/src/move_object_atomic.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
use Google\Cloud\Storage\StorageClient;
2828

2929
/**
30-
* Move an object to a new name within HNS-enabled bucket.
30+
* Move an object to a new name within bucket.
3131
*
3232
* @param string $bucketName The name of your Cloud Storage bucket.
3333
* (e.g. 'my-bucket')

storage/test/ObjectsTest.php

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -153,29 +153,27 @@ public function testManageObject()
153153

154154
public function testMoveObjectAtomic()
155155
{
156-
$bucketName = self::$bucketName . '-hns';
157156
$objectName = 'test-object-' . time();
158157
$newObjectName = $objectName . '-moved';
159-
$bucket = self::$storage->createBucket($bucketName, [
160-
'hierarchicalNamespace' => ['enabled' => true],
158+
$bucket = self::$storage->createBucket(self::$bucketName, [
161159
'iamConfiguration' => ['uniformBucketLevelAccess' => ['enabled' => true]]
162160
]);
163161

164162
$object = $bucket->upload('test', ['name' => $objectName]);
165163
$this->assertTrue($object->exists());
166164

167165
$output = self::runFunctionSnippet('move_object_atomic', [
168-
$bucketName,
166+
self::$bucketName,
169167
$objectName,
170168
$newObjectName
171169
]);
172170

173171
$this->assertEquals(
174172
sprintf(
175173
'Moved gs://%s/%s to gs://%s/%s' . PHP_EOL,
176-
$bucketName,
174+
self::$bucketName,
177175
$objectName,
178-
$bucketName,
176+
self::$bucketName,
179177
$newObjectName
180178
),
181179
$output

0 commit comments

Comments
 (0)