-
Notifications
You must be signed in to change notification settings - Fork 120
WIP: Headless broadcast #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
WIP: Headless broadcast #1105
Conversation
Hackey part yes, otherwise I would say this fits public API just fine.
Maybe we can split that off to include in next release? Unless you intend to finish this. |
|
Is there any intention of this being merged and put into release? I think this could be very useful for scenarios where game masters want ambient radio traffic over usable radios (as an example use case). |
|
Are there any plans to revive this and get it in - even as a dev / undocumented feature? It'll be useful for developing, but I can see the gameplay benefits of it as well. I've resolved the merge conflicts in my fork here if that helps at all. |
| TRACE_4("start",_unit,_tsName,_languageId,_speakingType,_radioId); | ||
|
|
||
| if (!alive _unit) exitWith { ERROR_1("bad unit",_this); false }; | ||
| if (!isNil {_unit getVariable [QGVAR(keepRunning), nil]}) exitWith { ERROR_1("unit is already active",_this); false }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of 'Arma 3' 2.18, the nil check could be simplified:
| if (!isNil {_unit getVariable [QGVAR(keepRunning), nil]}) exitWith { ERROR_1("unit is already active",_this); false }; | |
| if !(_unit isNil QGVAR(keepRunning)) exitWith { ERROR_1("unit is already active",_this); false }; |
| params ["_unit"]; | ||
| TRACE_1("stop"_unit); | ||
|
|
||
| if (isNil {_unit getVariable [QGVAR(keepRunning), nil]}) exitWith { ERROR_1("unit is not active",_this); }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise this could be simplified:
| if (isNil {_unit getVariable [QGVAR(keepRunning), nil]}) exitWith { ERROR_1("unit is not active",_this); }; | |
| if (_unit isNil QGVAR(keepRunning)) exitWith { ERROR_1("unit is not active",_this); }; |
|
Yeah, this PR opens a lot of possibilities for a wide variety of scenarios, like stations that people can listen to to get important mission related information by deciphering the signal or similar. Or just straight up playing radio on a specific frequency. |
Had a feature request to allow playing music via radios.
This allows an AI unit to talk or speak on radio with the use of
some external ts client that is outputting sound e.g.: https://github.com/Splamy/TS3AudioBot
https://www.youtube.com/watch?v=MTFx7xuhRjE
Example use:
Ultimately, I think this feature is just too niche (and kind of hackey) to add publicly.
But it does seem to be a useful tool in debugging.
also fun bug:
acre just expects mono microphone data, but TS is capable of stereo
without the mono fix, everything was pitch shifted lower because the sound data is interleaved [left, right, left]