fix: model and payload changes

Author: ChengShi-1

src/licenses/domain/models/License.ts

@@ -1,8 +1,14 @@
 export interface License {
   id: number
   name: string
+  shortDescription?: string
   uri: string
-  iconUrl: string
+  iconUri?: string
   active: boolean
   isDefault: boolean
+  sortOrder: number
+  rightsIdentifier?: string
+  rightsIdentifierScheme?: string
+  schemeUri?: string
+  languageCode?: string
 }

src/licenses/domain/repositories/transformers/LicensePayload.ts

@@ -1,14 +1,14 @@
 export interface LicensePayload {
   id: number
   name: string
-  shortDescription: string
+  shortDescription?: string
   uri: string
-  iconUrl: string
+  iconUrl?: string
   active: boolean
   isDefault: boolean
   sortOrder: number
-  rightsIdentifier: string
-  rightsIdentifierScheme: string
-  schemeUri: string
-  languageCode: string
+  rightsIdentifier?: string
+  rightsIdentifierScheme?: string
+  schemeUri?: string
+  languageCode?: string
 }

src/licenses/domain/repositories/transformers/licenseTransformers.ts

@@ -2,14 +2,21 @@ import { AxiosResponse } from 'axios'
 import { License } from '../../models/License'
 import { LicensePayload } from './LicensePayload'
 
-export const transformLicensesResponseToLicenses = (response: AxiosResponse): License[] => {
+export const transformPayloadToLicense = (response: AxiosResponse): License[] => {
   const payload = response.data.data as LicensePayload[]
+
   return payload.map((license: LicensePayload) => ({
     id: license.id,
     name: license.name,
+    shortDescription: license.shortDescription,
     uri: license.uri,
-    iconUrl: license.iconUrl,
+    iconUri: license.iconUrl, // in payload, it is called iconUrl, but iconUri is the name matching everywhere else
     active: license.active,
-    isDefault: license.isDefault
+    isDefault: license.isDefault,
+    sortOrder: license.sortOrder,
+    rightsIdentifier: license.rightsIdentifier,
+    rightsIdentifierScheme: license.rightsIdentifierScheme,
+    schemeUri: license.schemeUri,
+    languageCode: license.languageCode
   }))
 }

test/unit/licenses/GetAvailableStandardLicenses.test.ts

@@ -1,4 +1,4 @@
-import { ReadError } from '../../../src'
+import { License, ReadError } from '../../../src'
 import { ILicensesRepository } from '../../../src/licenses/domain/repositories/ILicensesRepository'
 import { GetAvailableStandardLicenses } from '../../../src/licenses/domain/useCases/GetAvailableStandardLicenses'
 
@@ -7,22 +7,32 @@ describe('GetAvailableStandardLicenses', () => {
     test('should return licenses array on repository success', async () => {
       const licensesRepositoryStub: ILicensesRepository = {} as ILicensesRepository
 
-      const testLicenses = [
+      const testLicenses: License[] = [
         {
           id: 1,
           name: 'CC0 1.0',
           uri: 'http://creativecommons.org/publicdomain/zero/1.0',
-          iconUrl: 'https://licensebuttons.net/p/zero/1.0/88x31.png',
+          iconUri: 'https://licensebuttons.net/p/zero/1.0/88x31.png',
           active: true,
-          isDefault: true
+          isDefault: true,
+          sortOrder: 0,
+          rightsIdentifier: 'CC0-1.0',
+          rightsIdentifierScheme: 'SPDX',
+          schemeUri: 'https://spdx.org/licenses/',
+          languageCode: 'en'
         },
         {
           id: 2,
           name: 'CC BY 4.0',
           uri: 'http://creativecommons.org/licenses/by/4.0',
-          iconUrl: 'https://licensebuttons.net/l/by/4.0/88x31.png',
+          iconUri: 'https://licensebuttons.net/l/by/4.0/88x31.png',
           active: true,
-          isDefault: false
+          isDefault: false,
+          sortOrder: 2,
+          rightsIdentifier: 'CC-BY-4.0',
+          rightsIdentifierScheme: 'SPDX',
+          schemeUri: 'https://spdx.org/licenses/',
+          languageCode: 'en'
         }
       ]