test: code coverage

Author: g-saracca

src/sections/shared/form/EditCreateCollectionForm/collection-form/top-fields-section/IdentifierField.tsx

@@ -19,9 +19,11 @@ export const collectionNameToAlias = (name: string) => {
 
 // This is only to avoid difference snapshots in Chromatic builds, the real display origin will be the current window location
 const locationOrigin =
-  import.meta.env.STORYBOOK_CHROMATIC_BUILD === 'true' ? 'https://foo.com' : window.location.origin
+  import.meta.env.STORYBOOK_CHROMATIC_BUILD === 'true'
+    ? /* istanbul ignore next */ 'https://foo.com'
+    : window.location.origin
 
-const BASENAME_URL = import.meta.env.BASE_URL ?? ''
+const BASENAME_URL = import.meta.env.BASE_URL ?? /* istanbul ignore next */ ''
 
 interface IdentifierFieldProps {
   rules: UseControllerProps['rules']

tests/component/sections/dataset/dataset-metadata/DatasetMetadata.spec.tsx

@@ -413,4 +413,75 @@ describe('DatasetMetadata', () => {
     cy.findByRole('button', { name: 'Citation Metadata' }).should('exist')
     cy.findByRole('button', { name: 'Geospatial Metadata' }).should('not.exist')
   })
+
+  it('adds name and description to extra fields of the citation metadata block', () => {
+    const mockDatasetWithExtraFields = DatasetMother.create({
+      metadataBlocks: [
+        {
+          name: MetadataBlockName.CITATION,
+          fields: {
+            title: 'Some Title',
+            subject: ['subject-one', 'subject-two'],
+            author: [
+              {
+                authorName: 'Foo',
+                authorAffiliation: 'Bar'
+              },
+              {
+                authorName: 'Another Foo',
+                authorAffiliation: 'Another Bar'
+              }
+            ],
+            datasetContact: [
+              {
+                datasetContactName: 'John Doe',
+                datasetContactEmail: '[email protected]',
+                datasetContactAffiliation: 'Doe Inc.'
+              }
+            ],
+            dsDescription: [
+              {
+                dsDescriptionValue: 'Description of the dataset'
+              }
+            ],
+            producer: [
+              {
+                producerName: 'Foo',
+                producerAffiliation: 'XYZ',
+                producerURL: 'http://foo.com',
+                producerLogoURL:
+                  'https://beta.dataverse.org/resources/images/dataverse_project_logo.svg'
+              }
+            ],
+            // Extra fields
+            publicationDate: '2023-01-01',
+            alternativePersistentId: 'some-alternative-pid'
+          }
+        }
+      ]
+    })
+
+    cy.customMount(
+      <DatasetMetadata
+        persistentId={mockDatasetWithExtraFields.persistentId}
+        metadataBlocks={mockDatasetWithExtraFields.metadataBlocks}
+        metadataBlockInfoRepository={metadataBlockInfoRepository}
+      />
+    )
+
+    cy.get('.accordion > :nth-child(1)').within(() => {
+      cy.findByText(/Citation Metadata/i).should('exist')
+
+      cy.findByText('Persistent Identifier')
+        .parent()
+        .siblings('div')
+        .should('contain', mockDatasetWithExtraFields.persistentId)
+
+      cy.findByText('Publication Date').should('exist')
+      cy.findByText('2023-01-01').should('exist')
+
+      cy.findByText('Previous Dataset Persistent ID').should('exist')
+      cy.findByText('some-alternative-pid').should('exist')
+    })
+  })
 })

tests/component/sections/file/file-embargo/FileEmbargoDate.spec.tsx

@@ -60,4 +60,17 @@ describe('FileEmbargoDate', () => {
     cy.findByText(`Embargoed until`).should('exist')
     cy.get('time').should('have.text', dateString)
   })
+
+  it('renders the embargo date in short format', () => {
+    const embargoDate = new Date('2123-09-18')
+    const embargo = FileEmbargoMother.create({ dateAvailable: embargoDate })
+    const status = DatasetPublishingStatus.RELEASED
+
+    cy.customMount(
+      <FileEmbargoDate embargo={embargo} datasetPublishingStatus={status} format="short" />
+    )
+    const dateString = DateHelper.toDisplayFormat(embargoDate)
+    cy.findByText(`Embargoed until`).should('exist')
+    cy.get('time').should('have.text', dateString)
+  })
 })