Apply suggestions from code review

Author: climbfuji

configs/sites/tier1/blueback/packages.yaml

@@ -87,8 +87,6 @@ packages:
     externals:
     - spec: [email protected]
       prefix: /p/app/projects/NEPTUNE/spack-stack/qt-5.15.2/5.15.2/gcc_64
-      #modules:
-      #- qt/5.15.2
   sed:
     externals:
     - spec: [email protected]

util/nrl/batch_install.sh

@@ -463,17 +463,6 @@ for compiler in "${SPACK_STACK_BATCH_COMPILERS[@]}"; do
     fi
     spack env activate -p ${env_dir}
 
-    ## Workaround for building cylc environment on Narwhal: We need to use GNU
-    ## compilers without the Cray wrappers. Until we can come up with a smarter
-    ## solution, use this.
-    #if [[ ${host} == "narwhal" && ${template} == "cylc-dev" ]]; then
-    #  echo "Applying workaround for ${template} on ${host}"
-    #  cp -av configs/sites/tier1/narwhal/compilers.gcc-direct.tmp ${env_dir}/site/compilers.yaml
-    #elif [[ ${host} == "blueback" && ${template} == "cylc-dev" ]]; then
-    #  echo "Applying workaround for ${template} on ${host}"
-    #  cp -av configs/sites/tier1/blueback/compilers.gcc-direct.tmp ${env_dir}/site/compilers.yaml
-    #fi
-
     # Update bootstrap mirror if requested
     if [[ "${update_bootstrap_mirror}" == "true"*  ]]; then
       tmp_bootstrap_mirror_path=${PWD}/tmp-bootstrap-mirror-${env_name}
@@ -584,32 +573,6 @@ for compiler in "${SPACK_STACK_BATCH_COMPILERS[@]}"; do
       spack stack setup-meta-modules 2>&1 | tee log.setup-meta-modules.${env_name}.001
     fi
 
-    ## In install mode, run post-install scripts if applicable
-    #if [[ "${update_build_cache}" == "false" ]]; then
-    #  case ${host} in
-    #    atlantis)
-    #      ;;
-    #    blueback)
-    #      ;;
-    #    cole)
-    #      ;;
-    #    narwhal)
-    #      ;;
-    #    nautilus)
-    #      ;;
-    #    tusk)
-    #      ;;
-    #    blackpearl)
-    #      ;;
-    #    bounty)
-    #      ;;
-    #    *)
-    #      echo "ERROR, post-install scripts not configured for ${host}"
-    #      exit 1
-    #      ;;
-    #  esac
-    #fi
-
     # When creating or updating buildcaches, fix permissions for mirrors.
     # Mirrors do not contain executables, therefore skip looking for them.
     if [[ "${update_bootstrap_mirror}" == "true" ]]; then