Author: wumpz

pom.xml

@@ -124,6 +124,28 @@
                         <phase>process-sources</phase>
                     </execution>
                 </executions>
+                <dependencies>
+                    <dependency>
+                        <groupId>net.sourceforge.pmd</groupId>
+                        <artifactId>pmd-core</artifactId>
+                        <version>${pmdVersion}</version>
+                    </dependency>
+                    <dependency>
+                        <groupId>net.sourceforge.pmd</groupId>
+                        <artifactId>pmd-java</artifactId>
+                        <version>${pmdVersion}</version>
+                    </dependency>
+                    <dependency>
+                        <groupId>net.sourceforge.pmd</groupId>
+                        <artifactId>pmd-javascript</artifactId>
+                        <version>${pmdVersion}</version>
+                    </dependency>
+                    <dependency>
+                        <groupId>net.sourceforge.pmd</groupId>
+                        <artifactId>pmd-jsp</artifactId>
+                        <version>${pmdVersion}</version>
+                    </dependency>
+                </dependencies>
             </plugin>
             <plugin>
                 <groupId>org.codehaus.mojo</groupId>
@@ -610,6 +632,7 @@
 
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <pmdVersion>6.36.0</pmdVersion>
     </properties>
 
     <description>JSqlParser parses an SQL statement and translate it into a hierarchy of Java classes.

ruleset.xml

@@ -38,7 +38,7 @@ under the License.
     <!-- this little fellow will complain about PACKAGE based imports -->
     <!--<rule ref="category/java/bestpractices.xml/UnusedImports" /> -->
 
-    <rule ref="category/java/bestpractices.xml/UnusedFormalParameter" />
+    <!-- <rule ref="category/java/bestpractices.xml/UnusedFormalParameter" /> -->
     <rule ref="category/java/bestpractices.xml/UnusedLocalVariable" />
     <rule ref="category/java/bestpractices.xml/UnusedPrivateField" />
     <rule ref="category/java/bestpractices.xml/UnusedPrivateMethod" />

src/main/java/net/sf/jsqlparser/statement/update/Update.java

@@ -167,10 +167,11 @@ public Select getSelect() {
 
     @Deprecated
     public void setSelect(Select select) {
-        if (select!=null) {
+        if (select != null) {
             SubSelect subSelect = new SubSelect().withSelectBody(select.getSelectBody());
-            if (select.getWithItemsList() != null && select.getWithItemsList().size() > 0)
+            if (select.getWithItemsList() != null && select.getWithItemsList().size() > 0) {
                 subSelect.setWithItemsList(select.getWithItemsList());
+            }
 
             if (updateSets.get(0).expressions.isEmpty()) {
                 updateSets.get(0).expressions.add(subSelect);
@@ -192,11 +193,12 @@ public void setUseColumnsBrackets(boolean useColumnsBrackets) {
 
     @Deprecated
     public boolean isUseSelect() {
-        return (updateSets.get(0).expressions.get(0) instanceof SubSelect);
+        return updateSets.get(0).expressions.get(0) instanceof SubSelect;
     }
 
     @Deprecated
     public void setUseSelect(boolean useSelect) {
+        //todo
     }
 
     public void setOrderByElements(List<OrderByElement> orderByElements) {
@@ -260,8 +262,8 @@ public String toString() {
         }
         b.append(" SET ");
 
-        int j=0;
-        for (UpdateSet updateSet:updateSets) {
+        int j = 0;
+        for (UpdateSet updateSet : updateSets) {
             if (j > 0) {
                 b.append(", ");
             }
@@ -317,7 +319,6 @@ public String toString() {
 //            b.append(" = ");
 //            b.append("(").append(select).append(")");
 //        }
-
         if (fromItem != null) {
             b.append(" FROM ").append(fromItem);
             if (joins != null) {

src/main/java/net/sf/jsqlparser/statement/update/UpdateSet.java

@@ -1,3 +1,12 @@
+/*-
+ * #%L
+ * JSQLParser library
+ * %%
+ * Copyright (C) 2004 - 2021 JSQLParser
+ * %%
+ * Dual licensed under GNU LGPL 2.1 or Apache License 2.0
+ * #L%
+ */
 package net.sf.jsqlparser.statement.update;
 
 import net.sf.jsqlparser.expression.Expression;