Skip to content

Commit 1f08cfa

Browse files
Rename variable
1 parent c60042f commit 1f08cfa

File tree

4 files changed

+17
-17
lines changed

4 files changed

+17
-17
lines changed

src/main/java/org/jabref/gui/integrity/IntegrityCheckDialog.fxml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@
3232
<HBox maxHeight="30" spacing="10.0" alignment="CENTER_RIGHT">
3333
<HBox spacing="4.0">
3434
<ComboBox fx:id="entryTypeCombo" maxWidth="400" />
35-
<Button onAction="#fixByType" prefHeight="20.0" text="%Fix by type"/>
35+
<Button onAction="#resolveIssueByType" prefHeight="20.0" text="%Fix by type"/>
3636
</HBox>
37-
<Button onAction="#fixAll" prefHeight="20.0" text="%Fix all"/>
37+
<Button onAction="#resolveAll" prefHeight="20.0" text="%Fix all"/>
3838
</HBox>
3939
</VBox>
4040
</content>

src/main/java/org/jabref/gui/integrity/IntegrityCheckDialog.java

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ protected void updateItem(String item, boolean empty) {
126126
setGraphic(new Label(Localization.lang("No fix available")));
127127
} else {
128128
configureButton(issue.get().getFix().get(), () -> {
129-
viewModel.fix(issue.get(), rowData);
129+
viewModel.resolveIssue(issue.get(), rowData);
130130
removeRow(rowData);
131131
});
132132
setGraphic(button);
@@ -201,8 +201,8 @@ private void updateEntryTypeCombo() {
201201
entryTypeCombo.getSelectionModel().selectFirst();
202202
}
203203

204-
public void fix(IntegrityIssue issue, IntegrityMessage message) {
205-
viewModel.fix(issue, message);
204+
public void resolveIssue(IntegrityIssue issue, IntegrityMessage message) {
205+
viewModel.resolveIssue(issue, message);
206206
removeRow(message);
207207
}
208208

@@ -230,13 +230,13 @@ private boolean hasFix(IntegrityMessage message) {
230230
}
231231

232232
/**
233-
* Attempts to fix all {@link IntegrityMessage} objects of the selected type.
233+
* Attempts to resolve all {@link IntegrityMessage} objects of the selected type.
234234
* If fixes are available, they are applied, and the fixed messages are removed.
235235
* A notification is shown to indicate success or failure.
236236
*/
237237
@FXML
238-
private void fixByType() {
239-
AtomicBoolean fixed = new AtomicBoolean(false);
238+
private void resolveIssueByType() {
239+
AtomicBoolean resolved = new AtomicBoolean(false);
240240

241241
String selectedType = entryTypeCombo.getSelectionModel().getSelectedItem();
242242
Optional<IntegrityIssue> selectedIssue = Arrays.stream(IntegrityIssue.values())
@@ -248,29 +248,29 @@ private void fixByType() {
248248
// Filter messages matching the selected issue type and have a fix
249249
.filter(message -> message.message().equals(issue.getText()) && hasFix(message))
250250
.forEach(message -> {
251-
fix(issue, message);
252-
fixed.set(true);
251+
resolveIssue(issue, message);
252+
resolved.set(true);
253253
});
254254
});
255255

256256
updateEntryTypeCombo();
257257

258-
if (fixed.get()) {
259-
notificationService.notify(Localization.lang("Fixed successfully."));
258+
if (resolved.get()) {
259+
notificationService.notify(Localization.lang("Resolved successfully."));
260260
} else {
261261
notificationService.notify(Localization.lang("No fixes available."));
262262
}
263263
}
264264

265265
/**
266-
* Attempts to fix all {@link IntegrityMessage} objects that have a fix available.
266+
* Attempts to resolve all {@link IntegrityMessage} objects that have a fix available.
267267
* Messages with applicable fixes are processed, and the corresponding UI elements are updated.
268268
*/
269269
@FXML
270-
private void fixAll() {
270+
private void resolveAll() {
271271
messagesTable.getItems().stream()
272272
.filter(this::hasFix) // Filter all messages that have a fix
273-
.forEach(message -> IntegrityIssue.fromMessage(message).ifPresent(issue -> fix(issue, message)));
273+
.forEach(message -> IntegrityIssue.fromMessage(message).ifPresent(issue -> resolveIssue(issue, message)));
274274

275275
updateEntryTypeCombo();
276276
}

src/main/java/org/jabref/gui/integrity/IntegrityCheckDialogViewModel.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public ObservableList<IntegrityMessage> getMessages() {
4141
return messages;
4242
}
4343

44-
public void fix(IntegrityIssue issue, IntegrityMessage message) {
44+
public void resolveIssue(IntegrityIssue issue, IntegrityMessage message) {
4545
// fixes
4646
}
4747
}

src/main/resources/l10n/JabRef_en.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2204,7 +2204,7 @@ Message\ filter=Message filter
22042204
Fix=Fix
22052205
Fix\ all=Fix all
22062206
Fix\ by\ type=Fix by type
2207-
Fixed\ successfully.=Fixed successfully.
2207+
Resolved\ successfully.=Resolved successfully.
22082208
No\ fixes\ available.=No fixes available.
22092209
No\ fix\ available=No fix available
22102210

0 commit comments

Comments
 (0)