Merge branch 'main' into support-escaped-spaces

Author: Siedlerchr

.git-blame-ignore-revs

@@ -1,5 +1,8 @@
 # Automatic code reformatting
+f3cfa496e028dee1cafd0c47553f63cd1243bd8c
 c5bcad738fe6e8dfcb62442a426c2778241515a1
+10189bf2c1a6bc506f03461390f3cc46e5cc0651
+16fd6194b9a0b8282259c00b6fb0d4aa494e4b04
 
 # net.sf.jabref -> org.jabref
 b2ad6eb279f5def38fa21be12cb5dd4545c1ba1a
@@ -23,6 +26,6 @@ bf81b595a77f0f7f254872be6f05a063c44528d8
 
 # This commit should not exist
 185d7345946c29a2a4e2726c912be0c4db4810b9
-# Resulted in this problematic merge commits
+# ... and resulted in this problematic merge commits
 7e1645978b3028df5e65af19f0f819ddfd0f24aa
 a31f396765492ac12eaab228e33eb9d22487403b

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -14,7 +14,7 @@ body:
       label: JabRef version
       options:
         - "5.15 (latest release)"
-        - "6.0-alpha2"
+        - "6.0-alpha.3"
         - Latest development branch build (please note build date below)
         - Other (please describe below)
       description: The version as shown in the about dialog.
@@ -43,7 +43,7 @@ body:
 
   - type: checkboxes
     attributes:
-      label: Checked with the latest development build (copy version output from About dialog)
+      label: Checked with the [latest development build](https://builds.jabref.org/main/) (copy version output from About dialog)
       description: |
         Please always test if the bug is still reproducible in the latest development version. We are constantly improving JabRef and some bugs may already be fixed. If you already use a development version, ensure that you use the latest one.
         You can download the latest development build at: https://builds.jabref.org/main/ . **Please make a backup of your library before you try out this version.**

.github/PULL_REQUEST_TEMPLATE.md

@@ -7,11 +7,11 @@ Closes _____
 
 ### Steps to test
 
-<!-- Describe how reviewers can test this fix/feature. Ideally, think of how you would guide a beginner user of Jabef to try out your change. -->
+<!-- Describe how reviewers can test this fix/feature. Ideally, think of how you would guide a beginner user of JabRef to try out your change. -->
 <!-- You can add screenshots or videos (using Loom - https://www.loom.com or by just adding .mp4 files). -->
 <!-- (REPLACE THIS PARAGRAPH) -->
 
-<!-- YOU HAVE TO MODIFY THE ABOVE TEXT FIT YOUR PR. OTHERWISE, YOUR PR WILL BE CLOSED WITHOUT FURTHER COMMENT. -->
+<!-- YOU HAVE TO MODIFY THE ABOVE TEXT TO FIT YOUR PR. OTHERWISE, YOUR PR WILL BE CLOSED WITHOUT FURTHER COMMENT. -->
 
 ### Mandatory checks
 

.github/dependabot.yml

@@ -3,12 +3,13 @@ updates:
   - package-ecosystem: gradle
     directories:
       - "/build-logic"   # versions of 3rd party gradle plugins
+      - "jablib"
       - "/versions"      # versions of 3rd party dependencies of all JabRef modules
       - "/"              # plugins
     schedule:
       interval: weekly
-    labels:
-      - "dependencies"
+      day: sunday
+    labels: [ ]
     ignore:
       - dependency-name: com.microsoft.azure:applicationinsights-core
         versions:
@@ -20,9 +21,18 @@ updates:
     directory: "/"
     schedule:
       interval: weekly
-    labels:
-      - "dependencies"
+      day: sunday
+    labels: [ ]
   - package-ecosystem: "gitsubmodule"
     directory: "/"
     schedule:
       interval: weekly
+      day: sunday
+    labels: [ ]
+  - package-ecosystem: "maven"
+    directories:
+      - "jablib-examples/maven3/doi-to-bibtex"
+    schedule:
+      interval: weekly
+      day: sunday
+    labels: [ ]

.github/ghprcomment.yml

@@ -39,6 +39,16 @@
 
     You can then run these tests in IntelliJ to reproduce the failing tests locally.
     We offer a quick test running howto in the section [Final build system checks](https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/intellij-12-build.html#final-build-system-checks) in our setup guide.
+- jobName: format
+  workflowName: 'Source Code Tests'
+  message: >
+    Your code currently does not meet JabRef's code guidelines.
+    IntelliJ auto format covers some cases.
+    There seem to be issues with your code style and autoformat configuration.
+    Please reformat your code (<kbd>Ctrl</kbd>+<kbd>Alt</kbd>+<kbd>L</kbd>) and commit, then push.
+
+
+    In special cases, consider using `// formatter:off` and `// formatter:on` annotations to allow deviation from the code style.
 - jobName: Checkstyle
   workflowName: 'Source Code Tests'
   message: >
@@ -78,8 +88,8 @@
 
 # CHANGELOG.md and *.md
 
-- jobName: 'CHANGELOG.md needs to be modified'
-  workflowName: 'PR Tests'
+- jobName: 'CHANGELOG.md needs to be modified if indicated'
+  workflowName: 'Check PR CHANGELOG.md'
   message: >
     You ticked that you modified `CHANGELOG.md`, but no new entry was found there.
 
@@ -117,14 +127,14 @@
 # Submodules and branches
 
 - jobName: 'Submodules not modified'
-  workflowName: 'PR Tests'
+  workflowName: 'Check PR Modifications'
   message: >
     Your pull request modified git submodules.
 
 
     Please follow our [FAQ on submodules](https://devdocs.jabref.org/code-howtos/faq.html#submodules) to fix.
 - jobName: no-force-push
-  workflowName: 'PR Tests'
+  workflowName: 'Check PR Modifications'
   always: true
   message: >
     Hey, we noticed that you **force-pushed** your changes.
@@ -146,7 +156,7 @@
     Please [merge `upstream/main`](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork#syncing-a-fork-branch-from-the-command-line) with your code.
     For a step-by-step guide to resolve merge conflicts, see <https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line>.
 - jobName: 'Source branch is other than "main"'
-  workflowName: 'PR Tests'
+  workflowName: 'Check PR Modifications'
   message: >
     You committed your code on the `main` brach of your fork. This is a bad practice.
     The right way is to branch out from `main`, work on your patch/feature in that new branch, and then get that branch merged via the pull request (see [GitHub flow](https://docs.github.com/en/get-started/using-github/github-flow)).
@@ -160,42 +170,38 @@
 # PR hygiene
 
 - jobName: 'Ensure that contributor is assigned (fails if not commented on issue)'
-  workflowName: 'On PR opened/updated'
+  workflowName: 'Link PR to Issue'
   message: >
     You did not assign yourself to the issue.
     Thus, it looks like you skipped reading our [CONTRIBUTING.md](https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md), which explains exactly how to participate. No worries, it happens to the best of us.
 
 
     Give it a read, and you’ll discover the ancient wisdom of assigning issues to yourself. Trust me, it’s worth it. 🚀
 
-- jobName: 'PR title must not start with "Fix for issue <number>"'
-  workflowName: 'PR Tests'
+- jobName: 'PR title must not contain "issue <number>"'
+  workflowName: 'Check PR Format'
   always: true
   message: >
     The title of the pull request must not start with "Fix for issue xyz".
     Please use a concise one-line summary that explains what the fix or change actually does.
     Example of a good title: "Prevent crash when importing malformed BibTeX entries".
 - jobName: 'Mandatory Checks present'
-  workflowName: 'PR Tests'
+  workflowName: 'Check PR Format'
   always: true
   message: >
     You have removed the "Mandatory Checks" section from your pull request description. Please adhere to our [pull request template](https://github.com/JabRef/jabref/blob/main/.github/PULL_REQUEST_TEMPLATE.md?plain=1#L10).
 - jobName: 'PR checklist OK'
-  workflowName: 'PR Tests'
+  workflowName: 'Check PR Format'
   always: true
   message: >
     Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of `[x]` (done), `[ ]` (not done yet) or `[/]` (not applicable).
 - jobName: 'Determine issue number'
-  workflowName: 'PR Tests'
+  workflowName: 'Link PR to Issue'
   always: true
   message: |
     Your pull request needs to link an issue correctly.
 
-    To ease organizational workflows, please link this pull-request to the issue with syntax as described in <https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue>:
-
-    > <h2 id="linking-a-pull-request-to-an-issue-using-a-keyword">Linking a pull request to an issue using a keyword</h2>
-    > <p>You can link a pull request to an issue by using a supported keyword
-    > in the pull request's description or in a commit message.
+    To ease organizational workflows, please link this pull request to the issue by including a supported keyword in the pull request's description as per syntax described in [GitHub's documentation](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue).
 
     ### Examples
 

.github/workflows/automerge.yml

@@ -9,32 +9,41 @@ jobs:
   automerge:
     runs-on: ubuntu-latest
     if: github.repository == 'JabRef/jabref'
+    env:
+      HEAD_REPO: ${{ github.event.pull_request.head.repo.full_name }}
+      USER:      ${{ github.event.pull_request.user.login }}
+      TITLE:     ${{ github.event.pull_request.title }}
     steps:
       - name: Determine if job should run
         id: shouldrun
         shell: bash
         run: |
-          actor='${{ github.actor }}'
-          title='${{ github.event.pull_request.title }}'
+          echo USER: $USER
 
-          if [[ "$actor" == "renovate-bot" ]]; then
+          if [[ "$USER" == "renovate-bot" ]]; then
             echo "✅ from renote-bot"
             echo "shouldrun=true" >> "$GITHUB_OUTPUT"
             exit 0
           fi
 
-          head_repo="${{ github.event.pull_request.head.repo.full_name }}"
-          if [[ "$head_repo" != "JabRef/jabref" ]]; then
+          if [[ "$USER" == "dependabot[bot]" ]]; then
+            echo "✅ from dependabot"
+            echo "shouldrun=true" >> "$GITHUB_OUTPUT"
+            exit 0
+          fi
+
+          if [[ "$HEAD_REPO" != "JabRef/jabref" ]]; then
             echo "🚫 not from JabRef/jabref"
             echo "shouldrun=false" >> "$GITHUB_OUTPUT"
             exit 0
           fi
 
-          if [[ "$actor" == "dependabot[bot]" ]] || \
-            [[ "$title" == "[Bot] "* ]] || \
-            [[ "$title" == "Bump "* ]] || \
-            [[ "$title" == "New Crowdin updates"* ]] || \
-            [[ "$title" == "Update Gradle Wrapper from"* ]]; then
+          if [[ "$USER" == "dependabot[bot]" ]] || \
+            [[ "$TITLE" == "Chore(deps): "* ]] || \
+            [[ "$TITLE" == "[Bot] "* ]] || \
+            [[ "$TITLE" == "Bump "* ]] || \
+            [[ "$TITLE" == "New Crowdin updates"* ]] || \
+            [[ "$TITLE" == "Update Gradle Wrapper from"* ]]; then
             echo "✅ title OK"
             echo "shouldrun=true" >> "$GITHUB_OUTPUT"
             exit 0