re-added a getSuggestedFileName, used capitals for constant

Author: bblhd

jablib/src/main/java/org/jabref/logic/externalfiles/LinkedFileHandler.java

@@ -120,7 +120,7 @@ private record GetTargetPathResult(boolean exists, boolean renamed, Path path) {
     private GetTargetPathResult getTargetPath(Path sourcePath, Path targetDirectory, boolean useSuggestedName) throws IOException {
         Path suggestedFileName;
         if (useSuggestedName) {
-            suggestedFileName = Path.of(FileUtil.getFileExtension(sourcePath).orElse("pdf"));
+            suggestedFileName = Path.of(getSuggestedFileName(FileUtil.getFileExtension(sourcePath).orElse("pdf")));
         } else {
             suggestedFileName = sourcePath.getFileName();
         }

jablib/src/main/java/org/jabref/model/entry/LinkedFile.java

@@ -40,7 +40,7 @@ public class LinkedFile implements Serializable {
 
     private static final LinkedFile NULL_OBJECT = new LinkedFile("", Path.of(""), "");
 
-    private static final String pathDelimiter = System.getProperty("file.separator");
+    private static final String PATH_DELIM = System.getProperty("file.separator");
 
     // We have to mark these properties as transient because they can't be serialized directly
     private transient StringProperty description = new SimpleStringProperty();
@@ -235,8 +235,8 @@ public Optional<String> getFileName() {
         String linkedName = link.get();
         if (isOnlineLink(linkedName)) {
             return FileUtil.getFileNameFromUrl(linkedName);
-        } else if (pathDelimiter != null) {
-            int slash = linkedName.lastIndexOf(pathDelimiter);
+        } else if (PATH_DELIM != null) {
+            int slash = linkedName.lastIndexOf(PATH_DELIM);
             if (slash >= 0) {
                 return Optional.of(FileUtil.getValidFileName(linkedName.substring(slash + 1)));
             } else {