Skip to content

Commit b2302be

Browse files
committed
refactor
1 parent 69cfaf9 commit b2302be

File tree

2 files changed

+18
-11
lines changed

2 files changed

+18
-11
lines changed

jabls/src/main/java/module-info.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,5 @@
1717
requires org.eclipse.lsp4j.jsonrpc;
1818
requires org.eclipse.lsp4j.websocket;
1919
requires org.jspecify;
20-
requires org.jetbrains.annotations;
2120

2221
}

jabls/src/main/java/org/jabref/languageserver/BibtexTextDocumentService.java

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@
2222
import org.eclipse.lsp4j.DocumentLinkParams;
2323
import org.eclipse.lsp4j.Location;
2424
import org.eclipse.lsp4j.LocationLink;
25+
import org.eclipse.lsp4j.TextDocumentContentChangeEvent;
26+
import org.eclipse.lsp4j.TextDocumentItem;
27+
import org.eclipse.lsp4j.VersionedTextDocumentIdentifier;
2528
import org.eclipse.lsp4j.jsonrpc.messages.Either;
2629
import org.eclipse.lsp4j.services.LanguageClient;
2730
import org.eclipse.lsp4j.services.TextDocumentService;
@@ -41,7 +44,7 @@ public class BibtexTextDocumentService implements TextDocumentService {
4144
private final Map<String, String> contentCache;
4245
private LanguageClient client;
4346

44-
public BibtexTextDocumentService(RemoteMessageHandler messageHandler, @NonNull LspClientHandler clientHandler, @NonNull LspDiagnosticHandler diagnosticHandler, @NonNull LspLinkHandler linkHandler) {
47+
public BibtexTextDocumentService(@NonNull RemoteMessageHandler messageHandler, @NonNull LspClientHandler clientHandler, @NonNull LspDiagnosticHandler diagnosticHandler, @NonNull LspLinkHandler linkHandler) {
4548
this.clientHandler = clientHandler;
4649
this.diagnosticHandler = diagnosticHandler;
4750
this.linkHandler = linkHandler;
@@ -56,23 +59,28 @@ public void setClient(LanguageClient client) {
5659

5760
@Override
5861
public void didOpen(DidOpenTextDocumentParams params) {
59-
LOGGER.debug("didOpen {}", params.getTextDocument().getUri());
60-
fileUriToLanguageId.putIfAbsent(params.getTextDocument().getUri(), params.getTextDocument().getLanguageId());
61-
if ("bibtex".equals(params.getTextDocument().getLanguageId())) {
62-
diagnosticHandler.computeAndPublishDiagnostics(client, params.getTextDocument().getUri(), params.getTextDocument().getText(), params.getTextDocument().getVersion());
62+
TextDocumentItem textDocument = params.getTextDocument();
63+
LOGGER.debug("didOpen {}", textDocument.getUri());
64+
fileUriToLanguageId.putIfAbsent(textDocument.getUri(), textDocument.getLanguageId());
65+
66+
if ("bibtex".equals(textDocument.getLanguageId())) {
67+
diagnosticHandler.computeAndPublishDiagnostics(client, textDocument.getUri(), textDocument.getText(), textDocument.getVersion());
6368
} else {
64-
contentCache.put(params.getTextDocument().getUri(), params.getTextDocument().getText());
69+
contentCache.put(textDocument.getUri(), textDocument.getText());
6570
}
6671
}
6772

6873
@Override
6974
public void didChange(DidChangeTextDocumentParams params) {
70-
LOGGER.debug("didChange {}", params.getTextDocument().getUri());
71-
String languageId = fileUriToLanguageId.get(params.getTextDocument().getUri());
75+
VersionedTextDocumentIdentifier textDocument = params.getTextDocument();
76+
TextDocumentContentChangeEvent contentChange = params.getContentChanges().getFirst();
77+
LOGGER.debug("didChange {}", textDocument.getUri());
78+
String languageId = fileUriToLanguageId.get(textDocument.getUri());
79+
7280
if ("bibtex".equalsIgnoreCase(languageId)) {
73-
diagnosticHandler.computeAndPublishDiagnostics(client, params.getTextDocument().getUri(), params.getContentChanges().getFirst().getText(), params.getTextDocument().getVersion());
81+
diagnosticHandler.computeAndPublishDiagnostics(client, textDocument.getUri(), contentChange.getText(), textDocument.getVersion());
7482
} else {
75-
contentCache.put(params.getTextDocument().getUri(), params.getContentChanges().getFirst().getText());
83+
contentCache.put(textDocument.getUri(), contentChange.getText());
7684
}
7785
}
7886

0 commit comments

Comments
 (0)