Convert fixed-value ComboBoxes to SearchableComboBox (#14083) (#14165)

* Convert fixed-value ComboBoxes to SearchableComboBox (#14083)

* Move SearchableComboBox changelog entry to Unreleased section

* Fix CHANGELOG.md formatting - remove extra blank lines

* Set editable=false for pushToApplicationCombo as suggested

* Document change to ComboBoxes for usability

Updated CHANGELOG to include changes regarding ComboBoxes.

* Update CHANGELOG.md

* Remove duplicate addNewField block after merge and clean FXML structure

Author: CodeRishiX

CHANGELOG.md

@@ -22,6 +22,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - We separated the "Clean up entries" dialog into three tabs for clarity [#13819](https://github.com/JabRef/jabref/issues/13819)
 - `JabKit`: `--porcelain` does not output any logs to the console anymore. [#14244](https://github.com/JabRef/jabref/pull/14244)
 - <kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>L</kbd> now opens the terminal in the active library directory. [#14130](https://github.com/JabRef/jabref/issues/14130)
+- We changed  fixed-value ComboBoxes to SearchableComboBox for better usability. [#14083](https://github.com/JabRef/jabref/issues/14083)
 
 ### Fixed
 

jabgui/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneView.java

@@ -5,7 +5,6 @@
 import javafx.beans.value.ObservableBooleanValue;
 import javafx.css.PseudoClass;
 import javafx.scene.control.Button;
-import javafx.scene.control.ComboBox;
 import javafx.scene.control.TextField;
 import javafx.scene.control.Tooltip;
 import javafx.scene.input.KeyCode;
@@ -27,6 +26,7 @@
 import org.jabref.logic.l10n.Localization;
 
 import com.tobiasdiez.easybind.EasyBind;
+import org.controlsfx.control.SearchableComboBox;
 
 public class WebSearchPaneView extends VBox {
 
@@ -84,8 +84,8 @@ private void addQueryValidationHints(TextField query) {
     /**
      * Create combo box for selecting fetcher
      */
-    private ComboBox<SearchBasedFetcher> createFetcherComboBox() {
-        ComboBox<SearchBasedFetcher> fetchers = new ComboBox<>();
+    private SearchableComboBox<SearchBasedFetcher> createFetcherComboBox() {
+        SearchableComboBox<SearchBasedFetcher> fetchers = new SearchableComboBox<>();
         new ViewModelListCellFactory<SearchBasedFetcher>()
                 .withText(SearchBasedFetcher::getName)
                 .install(fetchers);

jabgui/src/main/java/org/jabref/gui/preferences/external/ExternalTab.java

@@ -4,7 +4,6 @@
 import javafx.fxml.FXML;
 import javafx.scene.control.Button;
 import javafx.scene.control.CheckBox;
-import javafx.scene.control.ComboBox;
 import javafx.scene.control.TextField;
 
 import org.jabref.gui.actions.ActionFactory;
@@ -20,12 +19,13 @@
 
 import com.airhacks.afterburner.views.ViewLoader;
 import de.saxsys.mvvmfx.utils.validation.visualization.ControlsFxVisualizer;
+import org.controlsfx.control.SearchableComboBox;
 
 public class ExternalTab extends AbstractPreferenceTabView<ExternalTabViewModel> implements PreferencesTab {
 
     @FXML private TextField eMailReferenceSubject;
     @FXML private CheckBox autoOpenAttachedFolders;
-    @FXML private ComboBox<GuiPushToApplication> pushToApplicationCombo;
+    @FXML private SearchableComboBox<GuiPushToApplication> pushToApplicationCombo;
     @FXML private TextField citeCommand;
     @FXML private Button autolinkExternalHelp;
 

jabgui/src/main/java/org/jabref/gui/preferences/general/GeneralTab.java

@@ -32,10 +32,11 @@
 import com.tobiasdiez.easybind.EasyBind;
 import de.saxsys.mvvmfx.utils.validation.visualization.ControlsFxVisualizer;
 import jakarta.inject.Inject;
+import org.controlsfx.control.SearchableComboBox;
 
 public class GeneralTab extends AbstractPreferenceTabView<GeneralTabViewModel> implements PreferencesTab {
 
-    @FXML private ComboBox<Language> language;
+    @FXML private SearchableComboBox<Language> language;
     @FXML private ComboBox<ThemeTypes> theme;
     @FXML private CheckBox themeSyncOs;
     @FXML private TextField customThemePath;

jabgui/src/main/resources/org/jabref/gui/preferences/external/ExternalTab.fxml

@@ -2,7 +2,6 @@
 
 <?import javafx.scene.control.Button?>
 <?import javafx.scene.control.CheckBox?>
-<?import javafx.scene.control.ComboBox?>
 <?import javafx.scene.control.Label?>
 <?import javafx.scene.control.TextField?>
 <?import javafx.scene.control.Tooltip?>
@@ -12,6 +11,7 @@
 <?import javafx.scene.layout.RowConstraints?>
 <?import javafx.scene.layout.VBox?>
 <?import org.jabref.gui.icon.JabRefIconView?>
+<?import org.controlsfx.control.SearchableComboBox?>
 <fx:root spacing="10.0" type="VBox"
          xmlns="http://javafx.com/javafx" xmlns:fx="http://javafx.com/fxml"
          fx:controller="org.jabref.gui.preferences.external.ExternalTab">
@@ -41,8 +41,8 @@
                 <RowConstraints minHeight="10.0" vgrow="SOMETIMES"/>
             </rowConstraints>
             <Label text="%Application to push entries to"/>
-            <ComboBox fx:id="pushToApplicationCombo"
-                      prefWidth="200.0" GridPane.columnIndex="1"/>
+            <SearchableComboBox fx:id="pushToApplicationCombo"
+                                prefWidth="200.0" GridPane.columnIndex="1"  editable="false"/>
             <Button styleClass="icon-button,narrow" onAction="#pushToApplicationSettings"
                     prefHeight="20.0" prefWidth="20.0" GridPane.columnIndex="2">
                 <graphic>

jabgui/src/main/resources/org/jabref/gui/preferences/general/GeneralTab.fxml

@@ -14,6 +14,7 @@
 <?import javafx.scene.layout.HBox?>
 <?import javafx.scene.layout.VBox?>
 <?import org.jabref.gui.icon.JabRefIconView?>
+<?import org.controlsfx.control.SearchableComboBox?>
 <fx:root spacing="10.0" type="VBox"
          xmlns="http://javafx.com/javafx" xmlns:fx="http://javafx.com/fxml"
          fx:controller="org.jabref.gui.preferences.general.GeneralTab">
@@ -28,7 +29,7 @@
                GridPane.rowIndex="0" GridPane.columnIndex="0" GridPane.columnSpan="3"/>
         <Label text="%Language"
                GridPane.rowIndex="1" GridPane.columnIndex="0"/>
-        <ComboBox fx:id="language" prefWidth="200.0"
+        <SearchableComboBox fx:id="language" prefWidth="200.0" editable="false"
                   GridPane.rowIndex="1" GridPane.columnIndex="1"/>
 
         <Label text="%Visual theme"