fixed that suggestedFileNames were assumed Optional in test, and runaway format case

Author: bblhd

jablib/src/test/java/org/jabref/logic/externalfiles/LinkedFileHandlerTest.java

@@ -81,9 +81,9 @@ void getSuggestedFileName(String expectedFileName, String link, String extension
         final LinkedFileHandler linkedFileHandler = new LinkedFileHandler(linkedFile, entry, databaseContext, filePreferences);
 
         if (extension.isEmpty()) {
-            assertEquals(expectedFileName, linkedFileHandler.getSuggestedFileName(extension).orElse("file" + "." + extension));
+            assertEquals(expectedFileName, linkedFileHandler.getSuggestedFileName(extension));
         } else {
-            assertEquals(expectedFileName, linkedFileHandler.getSuggestedFileName().orElse("file"));
+            assertEquals(expectedFileName, linkedFileHandler.getSuggestedFileName());
         }
     }
 

jablib/src/test/java/org/jabref/logic/util/io/FileUtilTest.java

@@ -229,23 +229,25 @@ void getFileNameWithMultipleDotsString() {
     }
 
     @ParameterizedTest
+    // formatter:off
     @CsvSource(textBlock = """
-                    test.file, www.example.com/test.file
-                    test.file, http://www.example.com/test.file
-                    test.file, https://www.example.com/test.file
-                    test.file, www.example.com/path/to/test.file
-                    test.file, http://www.example.com/path/to/test.file
-                    test.file, https://www.example.com/path/to/test.file
-                    test.file, https://www.example.com/not\\a\\windows\\path/test.file
-                    test.file, https://www.example.com////test.file
-                    blank, https://www.example.com/path/to/blank
-                    blank, https://www.example.com/not\\a\\windows\\path/blank
-                    not\\a\\windows.file, https://www.example.com/path/to/not\\a\\windows.file
-                    test.file, https://www.example.com/path/to/file.pdf?field=value
-                    test.file, https://www.example.com/path/to/file.pdf?a=1&b=2
-                    test.file, https://www.example.com/path/to/file.pdf?search=for+a+file
-                    blank, https://www.example.com/path/to/blank?search=for+a+file
+               test.file, www.example.com/test.file
+               test.file, http://www.example.com/test.file
+               test.file, https://www.example.com/test.file
+               test.file, www.example.com/path/to/test.file
+               test.file, http://www.example.com/path/to/test.file
+               test.file, https://www.example.com/path/to/test.file
+               test.file, https://www.example.com/not\\a\\windows\\path/test.file
+               test.file, https://www.example.com////test.file
+               blank, https://www.example.com/path/to/blank
+               blank, https://www.example.com/not\\a\\windows\\path/blank
+               not\\a\\windows.file, https://www.example.com/path/to/not\\a\\windows.file
+               test.file, https://www.example.com/path/to/file.pdf?field=value
+               test.file, https://www.example.com/path/to/file.pdf?a=1&b=2
+               test.file, https://www.example.com/path/to/file.pdf?search=for+a+file
+               blank, https://www.example.com/path/to/blank?search=for+a+file
         """)
+    // formatter:on
     void getFileNameFromUrlsCorrectly(String file, String url) {
         assertEquals(file, FileUtil.getFileNameFromUrl(url).orElse("file.pdf"), "from '" + url + "'");
     }