Skip to content

Conversation

@DawydowGerman
Copy link

@DawydowGerman DawydowGerman commented Dec 7, 2025

Closes #14403

Addressed in this PR:

Steps to test

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

Hey @DawydowGerman! 👋

Thank you for contributing to JabRef!

We have automated checks in place, based on which you will soon get feedback if any of them are failing.

After all automated checks pass, a maintainer will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs.

Please re-check our AI Usage Policy to ensure that your pull request is in line with it. It also contains links to our contribution guide in case of any other doubts related to our contribution workflow.

@github-actions github-actions bot added first contrib status: changes-required Pull requests that are not yet complete labels Dec 7, 2025
@koppor
Copy link
Member

koppor commented Dec 8, 2025

@DawydowGerman it seems you rebased instead of merging..

To start with a clean commit we have following advice

Rebase everything as one commit on main

  • Precondition: JabRef/jabref is configured as upstream.
  • Fetch recent commits and prune non-existing branches: git fetch upstream --prune
  • Merge recent commits: git merge upstream/main
  • If there are conflicts, resolve them
  • Reset index to upstream/main: git reset upstream/main
  • Review the changes and create a new commit using git gui: git gui
  • Do a force push: git push -f origin

See also: https://help.github.com/articles/syncing-a-fork/

@DawydowGerman
Copy link
Author

@koppor, thank you for advice. I'll try to fix the issue.

* Remove defaults map filling
* Add getAutoCompletePreferencesFromBackingStore method
* Add getAutoCompletePreferencesFromBackingStore call to getAutoCompletePreferences method
* Add getAutoCompletePreferences calls to clear, importPreferences methods
* Add private constructor, setAll, getDefault methods


---------

Co-authored-by: Carl Christian Snethlage <[email protected]>
Co-authored-by: Oliver Kopp <[email protected]>
@DawydowGerman DawydowGerman force-pushed the DawydowGerman-fix-for-issue-14403 branch from 4e1b6e7 to 077b7f7 Compare December 8, 2025 20:01
@jabref-machine
Copy link
Collaborator

Hey, we noticed that you force-pushed your changes. Force pushing is a bad practice when working together on a project (mainly because it is not supported well by GitHub itself). Commits are lost and comments on commits lose their context, thus making it harder to review changes.

When the pull request is getting integrated into main, all commits will be squashed anyway. Thus, your individual commit history will not be visible in main.

In future, please avoid that. For now, you can continue working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first contrib status: changes-required Pull requests that are not yet complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable resetting of AutoCompletePreferences

3 participants