-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Added PersonNamesPlausibilityComparator to improve merge dialog selection for author fields #14546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PersonNamesPlausibilityComparator to improve merge dialog selection for author fields #14546
Conversation
| if (left == null || right == null) { | ||
| return ComparisonResult.UNDETERMINED; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure that one of it can be null?
I bet that both are non-null - and you can annotate the whole class as @Nullmarked (because nothing is null)
| var leftAuthors = AuthorList.parse(left); | ||
| var rightAuthors = AuthorList.parse(right); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No vars in JabRef code.
|
If possible, please add test cases, too. |
Closes #14454
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)Screenshot: Merge dialog selecting correct DOI author data
