Skip to content

Conversation

@D-Prasanth-Kumar
Copy link
Contributor

@D-Prasanth-Kumar D-Prasanth-Kumar commented Dec 7, 2025

Closes #14454

Mandatory checks

Screenshot: Merge dialog selecting correct DOI author data
Screenshot 2025-12-07 235210

@github-actions github-actions bot added the status: changes-required Pull requests that are not yet complete label Dec 7, 2025
Comment on lines 10 to 12
if (left == null || right == null) {
return ComparisonResult.UNDETERMINED;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure that one of it can be null?

I bet that both are non-null - and you can annotate the whole class as @Nullmarked (because nothing is null)

Comment on lines 14 to 15
var leftAuthors = AuthorList.parse(left);
var rightAuthors = AuthorList.parse(right);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No vars in JabRef code.

@koppor
Copy link
Member

koppor commented Dec 7, 2025

If possible, please add test cases, too.

@github-actions github-actions bot removed the status: changes-required Pull requests that are not yet complete label Dec 7, 2025
@koppor koppor added this pull request to the merge queue Dec 7, 2025
Merged via the queue into JabRef:main with commit 0d4ae96 Dec 7, 2025
49 checks passed
@D-Prasanth-Kumar D-Prasanth-Kumar deleted the feature/person-names-plausibility branch December 8, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add PersonNamesPlausibilityComparator

2 participants