commonmark: for link don't fallback to title anymore

Author: JohannesKaufmann

plugin/commonmark/render_link.go

@@ -71,10 +71,6 @@ func (c *commonmark) renderLink(ctx converter.Context, w converter.Writer, n *ht
 	ctx.RenderChildNodes(ctx, &buf, n)
 	content := buf.Bytes()
 
-	if len(bytes.TrimSpace(content)) == 0 {
-		// Fallback to the title
-		content = []byte(l.title)
-	}
 	if len(bytes.TrimSpace(content)) == 0 && c.config.LinkEmptyContentBehavior == LinkBehaviorSkip {
 		// There is *no content* inside the link. Now we have two options:
 		// Continue rendering as a link OR skip to let other renderers take over.

plugin/commonmark/testdata/GoldenFiles/link.in.html

@@ -18,7 +18,7 @@
 </a></p>
 <p><a href="/no_content"><br /></a></p>
 
-<!--no content but fallback-->
+<!--no content but title-->
 <p><a href="/no_content" title="link title"></a></p>
 
 
@@ -116,6 +116,29 @@
 <p>before  <a href="/">A</a>  middle  <a href="/">B</a>  after</p>
 
 
+<!--------------------------------------
+        Anchor Links in Headings
+--------------------------------------->
+
+<h1 id="intro">
+  <a href="#intro">Introduction</a>
+</h1>
+
+<h1 id="intro">
+  <a href="#intro" class="anchor"></a>
+  Introduction
+</h1>
+
+<h1 id="intro">
+  Introduction
+  <a href="#intro" class="anchor">#</a>
+</h1>
+
+<h1 id="intro">
+  <a href="#intro" class="anchor">🔗</a>
+  Introduction
+</h1>
+
 
 <!--------------------------------------
         Content and Combinations

plugin/commonmark/testdata/GoldenFiles/link.out.md

@@ -24,9 +24,9 @@
 
 [](/no_content)
 
-<!--no content but fallback-->
+<!--no content but title-->
 
-[link title](/no_content "link title")
+[](/no_content "link title")
 
 * * *
 
@@ -120,6 +120,18 @@ before [A](/) middle [B](/) after
 
 before [A](/) middle [B](/) after
 
+<!--------------------------------------
+        Anchor Links in Headings
+--------------------------------------->
+
+# [Introduction](#intro)
+
+# [](#intro)Introduction
+
+# Introduction [#](#intro)
+
+# [🔗](#intro) Introduction
+
 <!--------------------------------------
         Content and Combinations
 --------------------------------------->
@@ -200,7 +212,7 @@ second text](/page.html)
 
 <!--link with an svg-->
 
-[title](/ "title")
+[](/ "title")
 
 <!-- link and strong inside word -->