Correctly reuse storage with SubArrays #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The definition of IntVector caused an implicit copy to convert SA to a
Vector{Int}, negating the efforts to reuse memory. Replace it with @view to get
reasonable memory consumption.
Suffing sorting a 100 MiB UInt8 array (an aarch64 executable):
before fix 10.324155 seconds (75 allocations: 16.797 GiB, 1.12% gc time)
after fix 8.059011 seconds (26 allocations: 400.007 MiB, 0.00% gc time)
Comparison with a few commonly-used suffix sorting libraries:
libsais 7.563240 seconds (3 allocations: 400.000 MiB, 0.00% gc time)
divsufsort 4.244779 seconds (3 allocations: 400.000 MiB, 0.00% gc time)
quinnj
approved these changes
Jul 22, 2025
Collaborator
quinnj
left a comment
quinnj
left a comment
There was a problem hiding this comment.
Wowza; nice improvement!
Contributor
|
Do you want to setup a proper email address for contributions? I was about to merge and noticed that the authorship email address would be one of the whacky GitHub autogenerated email addresses. |
Contributor
Author
|
Is that for squashed merges? I've set my primary email to public now. |
Contributor
|
Yes, if you author locally whatever your local git email is configured to gets use by git and then pushed. GitHub needs an email address when it's synthesizing a commit for you (like a squash). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The definition of IntVector caused an implicit copy to convert SA to a Vector{Int}, negating the efforts to reuse memory. Replace it with
@viewto get reasonable memory consumption.Suffix sorting a 100 MiB UInt8 array (an aarch64 executable):
Comparison with a few commonly-used suffix sorting libraries: