-
Notifications
You must be signed in to change notification settings - Fork 53
Reduce memory allocation when squaring a nested Taylor1 #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hve you checked that everything is ok in TaylorIntegration, in particular wrt the use of |
In my computer, all TaylorIntegration tests pass except for those related to the DiffEq extension, which I reckon is not related to this PR. |
|
I've also noticed that on my computer; I think it is due to some recent upgrade in DiffEq, that I haven't yet traced back |
|
Incidentally, when you bump the patch version related to this PR, can you also include compatibility with IA v0.23 (so it works with 0.23 and 1 as well)? See this for some context. |
Done. If you have no further comments, I think this PR is ready... |
|
Thanks a lot for this improvement! |
In master, running the following block of code:
produces the following output:
showing that squaring a nested Taylor1 allocates twice the memory. This PR proposes a quick fix.