-
Notifications
You must be signed in to change notification settings - Fork 11
Update FFMPEG to use 6.1.1 #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4884502
bump ffmpeg version
theogf 3eace52
remove avresample reference
theogf 2d3e355
revert remove bound
theogf 6670f89
update project version and lower julia bound
theogf caece51
remove drone
theogf e30a3ef
remove mention drone
theogf 6f92ddc
Remove AppVeyor
theogf 83d5d62
Merge branch 'master' into tgf/update-FFMPEG
IanButterworth 421816b
only bump the patch (non breaking change)
IanButterworth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| name = "FFMPEG" | ||
| uuid = "c87230d0-a227-11e9-1b43-d7ebe4e7570a" | ||
| authors = ["SimonDanisch <[email protected]>"] | ||
| version = "0.4.1" | ||
| version = "0.4.2" | ||
|
|
||
| [deps] | ||
| FFMPEG_jll = "b22a6f82-2f65-5046-a5b2-351ab43fb4e5" | ||
|
|
||
| [compat] | ||
| FFMPEG_jll = "4.3.1" | ||
| FFMPEG_jll = "4.3.1, 6.1.1" | ||
| julia = "^1.3" | ||
|
|
||
| [extras] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm.. I'm not sure about adding this in a patch release.
At least can we check VideoIO.jl tests before releasing this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, that would also mean moving the julia bound to 1.6
By this do you mean testing locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also move to v1.0.0 altogether, to avoid the mess of using only two version numbers, this package hasn't been touched in 3 years, looks moderately stable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could edit the VideoIO CI to dev this branch and test on a PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see there are these drone CI running on Julia 1.3 - 1.5, can I remove it safely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Drone service is completely broken, just remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also remove AppVeyor as the service in Julia is unmaintained and version still refers to 1.5