-
Notifications
You must be signed in to change notification settings - Fork 11
Update FFMPEG to use 6.1.1 #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
4884502
3eace52
2d3e355
6670f89
caece51
e30a3ef
6f92ddc
83d5d62
421816b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| .drone.jsonnet linguist-detectable=false | ||
|
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,7 @@ arch: | |
| - x86 | ||
| - arm64 | ||
| julia: | ||
| - 1.5 | ||
| - 1.6 | ||
| - 1 | ||
| - nightly | ||
| matrix: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,14 @@ | ||
| name = "FFMPEG" | ||
| uuid = "c87230d0-a227-11e9-1b43-d7ebe4e7570a" | ||
| authors = ["SimonDanisch <[email protected]>"] | ||
| version = "0.4.2" | ||
| version = "1.0.0" | ||
|
|
||
| [deps] | ||
| FFMPEG_jll = "b22a6f82-2f65-5046-a5b2-351ab43fb4e5" | ||
|
|
||
| [compat] | ||
| FFMPEG_jll = "4.3.1" | ||
| julia = "^1.3" | ||
| FFMPEG_jll = "4.3.1, 6.1.1" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmmm.. I'm not sure about adding this in a patch release. At least can we check VideoIO.jl tests before releasing this
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I agree, that would also mean moving the julia bound to 1.6
By this do you mean testing locally?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe also move to v1.0.0 altogether, to avoid the mess of using only two version numbers, this package hasn't been touched in 3 years, looks moderately stable.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
You could edit the VideoIO CI to dev this branch and test on a PR
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I see there are these drone CI running on Julia 1.3 - 1.5, can I remove it safely?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Drone service is completely broken, just remove it.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I also remove AppVeyor as the service in Julia is unmaintained and version still refers to 1.5 |
||
| julia = "1.6" | ||
|
|
||
| [extras] | ||
| Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.