Rename the package from ClusterManagers.jl to HTCondorClusterManager.jl (#4)

Author: DilumAluthge

.github/workflows/ci.yml

@@ -16,7 +16,6 @@ jobs:
     timeout-minutes: 10
     needs:
       - unit-tests
-      - test-slurm
     # Important: the next line MUST be `if: always()`.
     # Do not change that line.
     # That line is necessary to make sure that this job runs even if tests fail.
@@ -25,13 +24,11 @@ jobs:
     steps:
       - run: |
           echo unit-tests: ${{ needs.unit-tests.result }}
-          echo test-slurm: ${{ needs.test-slurm.result }}
       - run: exit 1
         # The last line must NOT end with ||
         # All other lines MUST end with ||
         if: |
-          (needs.unit-tests.result != 'success') ||
-          (needs.test-slurm.result != 'success')
+          (needs.unit-tests.result != 'success')
   unit-tests:
     runs-on: ubuntu-latest
     timeout-minutes: 20
@@ -63,6 +60,7 @@ jobs:
         # If this is not a PR, then DO fail CI if the Codecov upload errors.
         fail_ci_if_error: ${{ github.event_name != 'pull_request' || github.repository == github.event.pull_request.head.repo.full_name }}
   test-slurm:
+    if: false
     runs-on: ubuntu-latest
     timeout-minutes: 20
     strategy:
@@ -100,18 +98,18 @@ jobs:
       run: |
         docker exec -t slurmctld pwd
         docker exec -t slurmctld ls -la
-        docker exec -t slurmctld ls -la ClusterManagers
+        docker exec -t slurmctld ls -la HTCondorClusterManager
     - name: Instantiate package
-      run: docker exec -t slurmctld julia --project=ClusterManagers -e 'import Pkg; @show Base.active_project(); Pkg.instantiate(); Pkg.status()'
+      run: docker exec -t slurmctld julia --project=HTCondorClusterManager -e 'import Pkg; @show Base.active_project(); Pkg.instantiate(); Pkg.status()'
     - name: Run tests without a Slurm allocation
-      run: docker exec -t slurmctld julia --project=ClusterManagers -e 'import Pkg; Pkg.test(; test_args=["slurm"])'
+      run: docker exec -t slurmctld julia --project=HTCondorClusterManager -e 'import Pkg; Pkg.test(; test_args=["slurm"])'
     - name: Run tests inside salloc
-      run: docker exec -t slurmctld salloc -t 00:10:00 -n 2 julia --project=ClusterManagers -e 'import Pkg; Pkg.test(; test_args=["slurm"], coverage=true)'
+      run: docker exec -t slurmctld salloc -t 00:10:00 -n 2 julia --project=HTCondorClusterManager -e 'import Pkg; Pkg.test(; test_args=["slurm"], coverage=true)'
     - name: Run tests inside sbatch
-      run: docker exec -t slurmctld ClusterManagers/ci/run_my_sbatch.sh
+      run: docker exec -t slurmctld HTCondorClusterManager/ci/run_my_sbatch.sh
     - run: find . -type f -name '*.cov'
     - name: Copy .cov files out of the Docker container
-      run: docker exec slurmctld /bin/bash -c 'cd /home/docker/ClusterManagers && tar -cf - src/*.cov' | tar -xvf -
+      run: docker exec slurmctld /bin/bash -c 'cd /home/docker/HTCondorClusterManager && tar -cf - src/*.cov' | tar -xvf -
     - run: find . -type f -name '*.cov'
     # - run: find . -type f -name '*.cov' -exec cat {} \;
     - uses: julia-actions/julia-processcoverage@v1

Project.toml

@@ -1,4 +1,4 @@
-name = "ClusterManagers"
+name = "HTCondorClusterManager"
 uuid = "1076c17b-1fcc-416f-99d3-1c6bb2eb7749"
 version = "1.1.0"
 

src/ClusterManagers.jl renamed to src/HTCondorClusterManager.jl

@@ -1,4 +1,4 @@
-module ClusterManagers
+module HTCondorClusterManager
 
 using Distributed
 using Sockets

src/condor.jl

@@ -55,9 +55,9 @@ function launch(manager::HTCManager, params::Dict, instances_arr::Array, c::Cond
     let
         mgr_desc = "HTCondor"
         msg = "The $(mgr_desc) functionality in ClusterManagers.jl is currently not actively maintained. " *
-              "We are currently looking for a new maintainer. " * 
+              "We are currently looking for a new maintainer. " *
               "If you are an active user of the $(mgr_desc) functionality and are interested in becoming the maintainer, " *
-              "Please open an issue on the JuliaParallel/ClusterManagers.jl repo: " * 
+              "Please open an issue on the JuliaParallel/ClusterManagers.jl repo: " *
               "https://github.com/JuliaParallel/ClusterManagers.jl/issues"
         Base.depwarn(msg, Symbol(typeof(manager)))
     end

src/elastic.jl

@@ -150,7 +150,7 @@ function get_connect_cmd(em::ElasticManager; absolute_exename=true, same_project
     join([
         exename,
         project...,
-        "-e 'using ClusterManagers; ClusterManagers.elastic_worker(\"$cookie\",\"$ip\",$port)'"
+        "-e 'import HTCondorClusterManager; HTCondorClusterManager.elastic_worker(\"$cookie\",\"$ip\",$port)'"
     ]," ")
 
 end

test/elastic.jl

@@ -4,7 +4,7 @@
     em = ElasticManager(addr=:auto, port=0)
 
     # launch worker
-    run(`sh -c $(ClusterManagers.get_connect_cmd(em))`, wait=false)
+    run(`sh -c $(HTCondorClusterManager.get_connect_cmd(em))`, wait=false)
 
     # wait at most TIMEOUT seconds for it to connect
     @test :ok == timedwait(TIMEOUT) do

test/runtests.jl

@@ -1,4 +1,4 @@
-import ClusterManagers
+import HTCondorClusterManager
 import Test
 
 import Distributed
@@ -10,11 +10,11 @@ using Distributed: procs, nprocs
 using Distributed: remotecall_fetch, @spawnat
 using Test: @testset, @test, @test_skip
 # ElasticManager:
-using ClusterManagers: ElasticManager
+using HTCondorClusterManager: ElasticManager
 # Slurm:
-using ClusterManagers: addprocs_slurm, SlurmManager
+using HTCondorClusterManager: addprocs_slurm, SlurmManager
 # SGE:
-using ClusterManagers: addprocs_sge, SGEManager
+using HTCondorClusterManager: addprocs_sge, SGEManager
 
 const test_args = lowercase.(strip.(ARGS))
 
@@ -23,7 +23,7 @@ const test_args = lowercase.(strip.(ARGS))
 slurm_is_installed() = !isnothing(Sys.which("sbatch"))
 qsub_is_installed() = !isnothing(Sys.which("qsub"))
 
-@testset "ClusterManagers.jl" begin
+@testset "HTCondorClusterManager.jl" begin
     include("elastic.jl")
 
     if slurm_is_installed()