Create alias FRInt32 for FixedRational{Int32, 25200}
#191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Benchmark Results (Julia v1.10)Time benchmarks
Memory benchmarks
|
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Contributor
|
Thanks Miles, love the simplifications here! Should this bit of the README also be updated now? DynamicQuantities.jl/README.md Line 331 in 5668cf2 - 3-element QuantityArray(::Vector{Float64}, ::Quantity{Float64, Dimensions{FixedRational{Int32, 25200}}}):
+ 3-element QuantityArray(::Vector{Float64}, ::Quantity{Float64, Dimensions{FRInt32}}):I also did some reading on why the type alias printing tests are failing, and my understanding is that this is actually by design? I'm still getting familiar with TestItems, but are things failing because it is creating its own module, leading to the fully qualified types we're seeing in CI, but not interactively? |
Member
Author
|
I don't think so b/c these ones are normal |
Member
Author
|
And thx, good catch |
Member
Author
|
This is what shows up in the REPL: 
Idk. Maybe the testset turns this off somehow... But even doing |
Co-authored-by: Ian Weaver <[email protected]>
Member
Author
|
Oh wait. You're totally right!!! My bad. Just saw this behavior: julia> module A
using DynamicQuantities
f() = println(FRInt32)
end
Main.A
julia> A.f()
DynamicQuantities.FRInt32
julia> using DynamicQuantities
julia> A.f()
FRInt32Which is ... sorta weird. But I guess means the tests need to accommodate. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 21 21
Lines 1292 1292
=======================================
Hits 1281 1281
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the printouts easier to read. Also this creates
FRInt8=FixedRational{Int8,12}which makes it less challenging to swap the dimensions type.@icweaver would you be up for a review?