fix ylims bug and add limits tests (#688)

Author: jkrumbiegel

src/makielayout/layoutables/axis.jl

@@ -429,7 +429,7 @@ function reset_limits!(ax; xauto = true, yauto = true)
         if yauto
             yautolimits(ax)
         else
-            left(ax.targetlimits[]), right(ax.targetlimits[])
+            bottom(ax.targetlimits[]), top(ax.targetlimits[])
         end
     else
         convert(Tuple{Float32, Float32}, mylims)

test/unit_tests/makielayout.jl

@@ -30,4 +30,60 @@ end
     @test sc ∉ ax.scene.plots
     empty!(ax)
     @test isempty(ax.scene.plots)
-end
+end
+
+@testset "Axis limits basics" begin
+    f = Figure()
+    ax = Axis(f[1, 1], targetlimits = BBox(0, 10, 0, 20), limits = (nothing, nothing))
+    @test ax.finallimits[] == BBox(0, 10, 0, 20)
+    @test ax.limits[] == (nothing, nothing)
+    xlims!(ax, -10, 10)
+    @test ax.limits[] == ((-10, 10), nothing)
+    @test ax.finallimits[] == BBox(-10, 10, 0, 20)
+    ylims!(ax, -20, 30)
+    @test ax.limits[] == ((-10, 10), (-20, 30))
+    @test ax.finallimits[] == BBox(-10, 10, -20, 30)
+    limits!(ax, -5, 5, -10, 10)
+    @test ax.finallimits[] == BBox(-5, 5, -10, 10)
+    @test ax.limits[] == ((-5, 5), (-10, 10))
+    ax.limits[] = (nothing, nothing)
+    ax.xautolimitmargin = (0, 0)
+    ax.yautolimitmargin = (0, 0)
+    scatter!(Point2f0[(0, 0), (1, 2)])
+    @test ax.limits[] == (nothing, nothing)
+    @test ax.targetlimits[] == BBox(0, 1, 0, 2)
+    @test ax.finallimits[] == BBox(0, 1, 0, 2)
+    scatter!(Point2f0(3, 4))
+    @test ax.limits[] == (nothing, nothing)
+    @test ax.targetlimits[] == BBox(0, 3, 0, 4)
+    @test ax.finallimits[] == BBox(0, 3, 0, 4)
+    limits!(ax, -1, 1, 0, 2)
+    @test ax.limits[] == ((-1, 1), (0, 2))
+    @test ax.targetlimits[] == BBox(-1, 1, 0, 2)
+    @test ax.finallimits[] == BBox(-1, 1, 0, 2)
+    scatter!(Point2f0(5, 6))
+    @test ax.limits[] == ((-1, 1), (0, 2))
+    @test ax.targetlimits[] == BBox(-1, 1, 0, 2)
+    @test ax.finallimits[] == BBox(-1, 1, 0, 2)
+    autolimits!(ax)
+    @test ax.limits[] == (nothing, nothing)
+    @test ax.targetlimits[] == BBox(0, 5, 0, 6)
+    @test ax.finallimits[] == BBox(0, 5, 0, 6)
+    xlims!(-10, 10)
+    @test ax.limits[] == ((-10, 10), nothing)
+    @test ax.targetlimits[] == BBox(-10, 10, 0, 6)
+    @test ax.finallimits[] == BBox(-10, 10, 0, 6)
+    scatter!(Point2f0(11, 12))
+    @test ax.limits[] == ((-10, 10), nothing)
+    @test ax.targetlimits[] == BBox(-10, 10, 0, 12)
+    @test ax.finallimits[] == BBox(-10, 10, 0, 12)
+    autolimits!(ax)
+    ylims!(ax, 5, 7)
+    @test ax.limits[] == (nothing, (5, 7))
+    @test ax.targetlimits[] == BBox(0, 11, 5, 7)
+    @test ax.finallimits[] == BBox(0, 11, 5, 7)
+    scatter!(Point2f0(-5, -7))
+    @test ax.limits[] == (nothing, (5, 7))
+    @test ax.targetlimits[] == BBox(-5, 11, 5, 7)
+    @test ax.finallimits[] == BBox(-5, 11, 5, 7)
+end