Skip to content

Commit 73eef7f

Browse files
committed
run subprocess with shell set to false
1 parent 9ca7d54 commit 73eef7f

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

android_clean_app.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ def add_element(self, message):
4242
bits = res.split('.')[-2:]
4343
self.elements.append((bits[0], bits[1]))
4444
else:
45-
print("The pattern '%s' seems to find nothing in the error message '%s'. We can't find the resource and can't remove it. The pattern might have changed, please check and report this in github issues." % (Issue.pattern, message))
45+
print("The pattern '%s' seems to find nothing in the error message '%s'. We can't find the resource and can't remove it. The pattern might have changed, please check and report this in github issues." % (
46+
Issue.pattern, message))
4647

4748

4849
def parse_args():
@@ -74,10 +75,10 @@ def run_lint_command():
7475
lint, app_dir, lint_result, ignore_layouts = parse_args()
7576
if not lint_result:
7677
lint_result = os.path.join(app_dir, 'lint-result.xml')
77-
call_result = subprocess.call([lint, app_dir, '--xml', lint_result], shell=True)
78+
call_result = subprocess.call([lint, app_dir, '--xml', lint_result])
7879
if call_result > 0:
79-
print('Running the command failed. Try running it from the console. Arguments for subprocess.call: {0}'.format(
80-
[lint, app_dir, '--xml', lint_result]))
80+
print('Running the command failed with result {}. Try running it from the console. Arguments for subprocess.call: {}'.format(
81+
call_result, [lint, app_dir, '--xml', lint_result]))
8182
return lint_result, app_dir, ignore_layouts
8283

8384

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import sys
33
from setuptools import setup, find_packages
44

5-
version = '0.1.2'
5+
version = '0.1.3'
66

77
def read(f):
88
return open(os.path.join(os.path.dirname(__file__), f)).read().strip()

0 commit comments

Comments
 (0)