Skip to content

Commit 47dbcb8

Browse files
committed
Merge pull request #623 from LearningLocker/issue/active-users
Fixes active users.
2 parents 62cd41b + 02e4d61 commit 47dbcb8

File tree

4 files changed

+6
-9
lines changed

4 files changed

+6
-9
lines changed

app/views/partials/lrs/backbone/templates.blade.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
<%= _id.mbox != null ? '<b>Email:</b> ' + _id.mbox : '' %>
9797
<%= _id.mbox_sha1sum != null ? '<b>Email:</b> ' + _id.mbox_sha1sum : '' %>
9898
<%= _id.openid != null ? '<b>OpenID:</b> ' + _id.openid : '' %>
99-
<%= _id.account != null ? '<b>Account:</b> ' + _id.account.homePage + _id.account.name : '' %>
99+
<%= _id.account != null ? '<b>Account:</b> ' + _id.account.homePage + '/' + _id.account.name : '' %>
100100
</script>
101101

102102
<script id="userList" type="text/template">

public/assets/js/lrs/collections/UserCollection.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ define([
1010
url: function(){
1111
return '../lrs/' + App.lrs_id + '/stats/activeUsers';
1212
},
13+
generateId: function (attrs) {
14+
return JSON.stringify(attrs._id);
15+
}
1316
});
1417

1518
return UserCollection;

public/assets/js/lrs/models/stats/UserModel.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,7 @@ define([
44
'app'
55
], function(_, Backbone, App) {
66

7-
var UserModel = Backbone.Model.extend({
8-
//urlRoot: '../lrs/' + App.lrs_id + '/stats/activeUsers',
9-
urlRoot: function(){
10-
return window.LL.siteroot + '/lrs/' + App.lrs_id + '/stats/activeUsers';
11-
},
12-
idAttribute: "_id"
13-
});
7+
var UserModel = Backbone.Model.extend({});
148

159
return UserModel;
1610

public/assets/js/lrs/views/actor/UserList.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ define([
1616
itemView: UserListView,
1717

1818
appendHtml: function(collectionView, itemView){
19-
collectionView.$("#active").append(itemView.el);
19+
collectionView.$("#active").append(itemView.el);
2020
}
2121

2222
});

0 commit comments

Comments
 (0)