♻️ reworked quick start tests

Author: GautierDele

phpunit.xml

@@ -18,8 +18,6 @@
     <env name="QUEUE_CONNECTION" value="sync"/>
     <env name="SESSION_DRIVER" value="array"/>
     <env name="TELESCOPE_ENABLED" value="false"/>
-    <env name="APP_ENV" value="testing"/>
-    <env name="DB_CONNECTION" value="testing"/>
   </php>
   <source>
     <include>

tests/Feature/Commands/QuickStartCommandTest.php

@@ -10,7 +10,7 @@ class QuickStartCommandTest extends TestCase
     protected function setUp(): void
     {
         parent::setUp();
-        $this->cleanUp();
+
         // Ensure api.php exists for tests
         if (! File::exists(base_path('routes/api.php'))) {
             File::put(base_path('routes/api.php'), '<?php');
@@ -27,9 +27,7 @@ protected function cleanUp(): void
     {
         File::deleteDirectory(app_path('Rest'));
         File::deleteDirectory(app_path('Models'));
-        if (File::exists(base_path('routes/api.php'))) {
-            File::put(base_path('routes/api.php'), '<?php');
-        }
+        File::delete(base_path('routes/api.php'));
     }
 
     public function test_quick_start_command_creates_necessary_files()
@@ -53,7 +51,6 @@ public function test_quick_start_command_updates_api_routes()
 
     public function test_quick_start_command_does_not_duplicate_routes()
     {
-        // Run the command twice
         $this->artisan('rest:quick-start')->assertExitCode(0);
         $this->artisan('rest:quick-start')->assertExitCode(0);
 
@@ -68,24 +65,18 @@ public function test_quick_start_command_updates_user_model_namespace()
         File::makeDirectory(app_path('Models'), 0755, true);
         File::put(app_path('Models/User.php'), '<?php namespace App\Models; class User {}');
 
-        // Run the command
         $this->artisan('rest:quick-start')->assertExitCode(0);
 
-        // Check if the files were created
         $this->assertFileExists(app_path('Rest/Resources/UserResource.php'));
         $this->assertFileExists(app_path('Rest/Controllers/UsersController.php'));
 
         $resourceContent = File::get(app_path('Rest/Resources/UserResource.php'));
         $controllerContent = File::get(app_path('Rest/Controllers/UsersController.php'));
 
-        // Check for the updated namespace in UserResource.php
         $this->assertStringContainsString('\App\Models\User::class', $resourceContent);
 
-        // Check for the updated namespace in UsersController.php
-        // TODO: We are putting this control in the comment line for now, because UsersController may not have this change made.
-        // $this->assertStringContainsString('\App\Models\User::class', $controllerContent);
+        $this->assertStringContainsString('\App\Rest\Resources\UserResource::class', $controllerContent);
 
-        // Additional check Let's check that the User model is used correctly in UserResource
         $this->assertStringContainsString('public static $model = \App\Models\User::class;', $resourceContent);
     }
 }

tests/Feature/TestCase.php

@@ -16,55 +16,11 @@ protected function setUp(): void
     {
         parent::setUp();
 
-        $this->loadMigrationsFrom(__DIR__.'/Support/Database/migrations');
-        $this->artisan('migrate', ['--database' => 'testing'])->run();
         $this->withAuthenticatedUser();
     }
 
     protected function resolveAuthFactoryClass()
     {
         return UserFactory::class;
     }
-
-    protected function getPackageProviders($app)
-    {
-        return [
-            \Lomkit\Rest\RestServiceProvider::class,
-        ];
-    }
-
-    protected function getEnvironmentSetUp($app)
-    {
-        $app['config']->set('database.default', 'testing');
-
-        $connection = env('DB_CONNECTION', 'sqlite');
-
-        switch ($connection) {
-            case 'mysql':
-                $app['config']->set('database.connections.testing', [
-                    'driver' => 'mysql',
-                    'host' => env('DB_HOST', '127.0.0.1'),
-                    'port' => env('DB_PORT', '3306'),
-                    'database' => 'rest',
-                    'username' => env('DB_USERNAME', 'root'),
-                    'password' => env('DB_PASSWORD', ''),
-                ]);
-                break;
-            case 'pgsql':
-                $app['config']->set('database.connections.testing', [
-                    'driver' => 'pgsql',
-                    'host' => env('DB_HOST', '127.0.0.1'),
-                    'port' => env('DB_PORT', '5432'),
-                    'database' => 'rest',
-                    'username' => env('DB_USERNAME', 'postgres'),
-                    'password' => env('DB_PASSWORD', 'postgres'),
-                ]);
-                break;
-            default:
-                $app['config']->set('database.connections.testing', [
-                    'driver' => 'sqlite',
-                    'database' => ':memory:',
-                ]);
-        }
-    }
 }