Merge pull request #32 from Lomkit/fix/relation-limit

✨ dont apply limits on relationships

Author: GautierDele

src/Http/Controllers/Controller.php

@@ -26,8 +26,6 @@ abstract class Controller extends \Illuminate\Routing\Controller
      */
     public static $resource;
 
-    //@TODO: voir si toutes ces manières de call en static c'est pas plus dérangeant qu'autre chose
-    //@TODO: surtout avec octane où il faut éviter le static !?
     /**
      * Get a fresh instance of the resource represented by the entry.
      *
@@ -39,6 +37,4 @@ public static function newResource(): Resource
 
         return new $resource;
     }
-
-    //@TODO: are controllers useless in a certain way ??
 }

src/Query/Traits/PerformSearch.php

@@ -51,11 +51,10 @@ public function search(array $parameters = []) {
             $this->applyAggregates($parameters['aggregates']);
         });
 
-        // @TODO: is this a problem also with HasMany ??
-        // @TODO: this will be the problem for every relation, need to fix this
-        // In case of BelongsToMany we cap the limit
-        $limit = $this->queryBuilder instanceof \Illuminate\Database\Eloquent\Relations\BelongsToMany ? 9999 : ($parameters['limit'] ?? 50);
-        $this->queryBuilder->limit($limit);
+        // In case we are in a relation we don't apply the limits since we dont know how much records will be related.
+        if (!$this->queryBuilder instanceof Relation) {
+            $this->queryBuilder->limit($parameters['limit'] ?? 50);
+        }
 
         return $this->queryBuilder;
     }