Skip to content

Commit aeeecc1

Browse files
committed
✨ removed failed method on actions
1 parent cbd5e26 commit aeeecc1

File tree

4 files changed

+2
-29
lines changed

4 files changed

+2
-29
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,8 @@ TODO
9090

9191
- Custom directives (Filters / sorting)
9292
- Automatic documentation with extension possible
93+
- Alias for includes / aggregates
94+
-
9395

9496
## Roadmap
9597

src/Actions/Action.php

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -96,19 +96,6 @@ public function handle(array $fields, \Illuminate\Support\Collection $models)
9696
//
9797
}
9898

99-
/**
100-
* Called in an action failed.
101-
*
102-
* @param \Exception $exception
103-
* @param array $fields
104-
* @param \Illuminate\Support\Collection $models
105-
* @return mixed
106-
*/
107-
public function failed(array $fields, Collection $models, $exception)
108-
{
109-
//
110-
}
111-
11299
/**
113100
* Called in an action failed.
114101
*

src/Actions/CallRestApiAction.php

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -59,17 +59,6 @@ public function handle()
5959
$this->action->setJob($this->job)->handle($this->fields, $this->models);
6060
}
6161

62-
/**
63-
* Call the failed method on the job instance.
64-
*
65-
* @param \Exception $e
66-
* @return void
67-
*/
68-
public function failed($e)
69-
{
70-
$this->action->failed($this->fields, $this->models, $e);
71-
}
72-
7362
/**
7463
* Get the display name for the queued job.
7564
*

tests/Support/Rest/Actions/ModifyNumberAction.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,4 @@ public function fields(RestRequest $request)
4343
]
4444
];
4545
}
46-
47-
public function failed(array $fields, Collection $models, $exception)
48-
{
49-
dump('FAILED');
50-
}
5146
}

0 commit comments

Comments
 (0)