Skip to content

Commit ba7f3ed

Browse files
committed
✅ assert soft deleted tests
1 parent 5ffbb58 commit ba7f3ed

File tree

3 files changed

+3
-14
lines changed

3 files changed

+3
-14
lines changed

src/Concerns/PerformsRestOperations.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ public function destroy(DestroyRequest $request) {
6060
$resource->performDelete($request, $model);
6161
}
6262

63-
//@TODO: il faut prévoir de pouvoir load des relations ici ?
6463
return $resource::newResponse()
6564
->resource($resource)
6665
->responsable($models);

src/Concerns/Resource/Relationable.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ public function relation($name) {
1919
return $relation->relation === $relationName;
2020
});
2121

22-
//TODO: be careful here, nested morph relation here are not supported, might need to protect params validator
2322
if ($isSubRelation && Str::contains($nestedRelation = Str::after($name, '.'), '.')) {
2423
return $relation->resource()->relation($nestedRelation);
2524
}

tests/Feature/Controllers/DeleteOperationsTest.php

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,7 @@ public function test_deleting_a_soft_deleted_model(): void
7777
);
7878

7979
$this->assertResourceModel($response, [$softDeletedModel], new SoftDeletedModelResource);
80-
$this->assertDatabaseHas('soft_deleted_models', [
81-
'id' => $softDeletedModel->getKey(),
82-
'deleted_at' => Carbon::parse($response->json('deleted_at'))
83-
]);
80+
$this->assertSoftDeleted($softDeletedModel);
8481
}
8582

8683
public function test_deleting_multiple_soft_deleted_models(): void
@@ -99,13 +96,7 @@ public function test_deleting_multiple_soft_deleted_models(): void
9996
);
10097

10198
$this->assertResourceModel($response, [$softDeletedModel, $softDeletedModel2], new SoftDeletedModelResource);
102-
$this->assertDatabaseHas('soft_deleted_models', [
103-
'id' => $softDeletedModel->getKey(),
104-
'deleted_at' => Carbon::parse($response->json('deleted_at'))
105-
]);
106-
$this->assertDatabaseHas('soft_deleted_models', [
107-
'id' => $softDeletedModel2->getKey(),
108-
'deleted_at' => Carbon::parse($response->json('deleted_at'))
109-
]);
99+
$this->assertSoftDeleted($softDeletedModel);
100+
$this->assertSoftDeleted($softDeletedModel2);
110101
}
111102
}

0 commit comments

Comments
 (0)