♻️ get the right resource on the build aggregate filter rules

Author: GautierDele

src/Rules/AggregateFilterable.php

@@ -63,19 +63,17 @@ public function resource($resource)
      */
     protected function buildValidationRules($attribute, $value)
     {
-        $rules = [];
+        $aggregateResource = $this->resource->relation($value['relation'])?->resource();
 
-        foreach ($this->data['search']['aggregates'] as $aggregate) {
-            $resource = $this->resource->relation($aggregate['relation'])?->resource();
-
-            if (is_null($this->resource)) {
-                continue;
-            }
-
-            array_push($rules, (new SearchRules($resource, app()->make(RestRequest::class), false))->filtersRules($resource, $attribute));
+        if (is_null($aggregateResource)) {
+            return [];
         }
 
-        return $rules;
+        return (new SearchRules($this->resource, app()->make(RestRequest::class), false))
+            ->filtersRules(
+                $aggregateResource,
+                $attribute.'.filters'
+            );
     }
 
     /**

src/Rules/SearchRules.php

@@ -297,11 +297,9 @@ protected function aggregatesRules(\Lomkit\Rest\Http\Resource $resource, string
             $prefix.'.*' => [
                 AggregateField::make()
                     ->resource($resource),
-            ],
-            $prefix.'.*.filters' => [
                 AggregateFilterable::make()
                     ->resource($resource),
-            ],
+            ]
         ];
     }
 }

tests/Feature/Controllers/SearchAggregatesOperationsTest.php

@@ -603,6 +603,54 @@ public function test_getting_a_list_of_resources_aggregating_by_sum_number_with_
         );
     }
 
+    public function test_getting_a_list_of_resources_aggregating_by_sum_number_with_other_number_filter(): void
+    {
+        $matchingModel = ModelFactory::new()
+            ->has(
+                BelongsToManyRelationFactory::new()
+                    ->count(20)
+            )
+            ->create()->fresh();
+        $matchingModel2 = ModelFactory::new()
+            ->has(
+                BelongsToManyRelationFactory::new()
+                    ->count(20)
+            )
+            ->create()->fresh();
+
+        Gate::policy(Model::class, GreenPolicy::class);
+        Gate::policy(BelongsToManyRelation::class, GreenPolicy::class);
+
+        $response = $this->post(
+            '/api/models/search',
+            [
+                'search' => [
+                    'aggregates' => [
+                        [
+                            'relation' => 'belongsToManyRelation',
+                            'type'     => 'sum',
+                            'field'    => 'number',
+                            'filters'  => [
+                                ['field' => 'other_number', 'operator' => '<', 'value' => 200],
+                            ],
+                        ],
+                    ],
+                ],
+            ],
+            ['Accept' => 'application/json']
+        );
+
+        $this->assertResourcePaginated(
+            $response,
+            [$matchingModel, $matchingModel2],
+            new ModelResource(),
+            [
+                ['belongs_to_many_relation_sum_number' => $matchingModel->belongsToManyRelation()->orderBy('belongs_to_many_relations.number', 'desc')->where('belongs_to_many_relations.other_number', '<', 200)->sum('belongs_to_many_relations.number')],
+                ['belongs_to_many_relation_sum_number' => $matchingModel2->belongsToManyRelation()->orderBy('belongs_to_many_relations.number', 'desc')->where('belongs_to_many_relations.other_number', '<', 200)->sum('belongs_to_many_relations.number')],
+            ]
+        );
+    }
+
     public function test_getting_a_list_of_resources_aggregating_by_count_with_filters(): void
     {
         $matchingModel = ModelFactory::new()

tests/Support/Database/Factories/BelongsToManyRelationFactory.php

@@ -23,6 +23,7 @@ public function definition()
     {
         return [
             'number' => fake()->numberBetween(-5000, 5000),
+            'other_number' => fake()->numberBetween(-5000, 5000),
         ];
     }
 }

tests/Support/Database/migrations/2023_02_00_000000_create_belongs_to_many_relations_table.php

@@ -15,6 +15,7 @@ public function up()
         Schema::create('belongs_to_many_relations', function (Blueprint $table) {
             $table->id();
             $table->integer('number')->default(0);
+            $table->integer('other_number')->default(0);
             $table->timestamps();
         });
     }

tests/Support/Rest/Resources/BelongsToManyResource.php

@@ -26,6 +26,7 @@ public function fields(RestRequest $request): array
         return [
             'id',
             'number',
+            'other_number'
         ];
     }
 }