Skip to content

Commit f758d35

Browse files
authored
Merge branch 'master' into feature/directives
2 parents 1c7c30a + 1307cfe commit f758d35

File tree

4 files changed

+2
-30
lines changed

4 files changed

+2
-30
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Laravel Rest Api is an elegant way to expose your app through an API, it takes f
66

77
## Requirements
88

9-
PHP 8.0+ and Laravel 8.0+
9+
PHP 8.1+ and Laravel 8.0+
1010

1111
# BETA
1212
Please note that this package is under beta and is not recommended to use for production environment for now. End of beta should be by October 2023.
@@ -90,6 +90,7 @@ TODO
9090

9191
- Automatic documentation with extension possible
9292
- Refactor actions listing to --> Get resource informations (fields exposed / actions / etc ? regroupe all those possibilities)
93+
- Alias for includes / aggregates
9394

9495
## Roadmap
9596

src/Actions/Action.php

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -99,19 +99,6 @@ public function handle(array $fields, \Illuminate\Support\Collection $models)
9999
//
100100
}
101101

102-
/**
103-
* Called in an action failed.
104-
*
105-
* @param \Exception $exception
106-
* @param array $fields
107-
* @param \Illuminate\Support\Collection $models
108-
* @return mixed
109-
*/
110-
public function failed(array $fields, Collection $models, $exception)
111-
{
112-
//
113-
}
114-
115102
/**
116103
* Register callbacks on the pending batch.
117104
*

src/Actions/CallRestApiAction.php

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -59,17 +59,6 @@ public function handle()
5959
$this->action->setJob($this->job)->handle($this->fields, $this->models);
6060
}
6161

62-
/**
63-
* Call the failed method on the job instance.
64-
*
65-
* @param \Exception $e
66-
* @return void
67-
*/
68-
public function failed($e)
69-
{
70-
$this->action->failed($this->fields, $this->models, $e);
71-
}
72-
7362
/**
7463
* Get the display name for the queued job.
7564
*

tests/Support/Rest/Actions/ModifyNumberAction.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,4 @@ public function fields(\Lomkit\Rest\Http\Requests\RestRequest $request): array
4444
]
4545
];
4646
}
47-
48-
public function failed(array $fields, Collection $models, $exception)
49-
{
50-
dump('FAILED');
51-
}
5247
}

0 commit comments

Comments
 (0)