Skip to content

Update docker-compose.yml #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update docker-compose.yml #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ services:
db:
image: mysql
container_name: "db_cont"
ports:
-"3306:3306"
Comment on lines +41 to +42
Copy link

@coderabbitai coderabbitai bot Apr 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Validate and tighten MySQL port exposure

The current port mapping is missing a space after the hyphen (invalid YAML syntax) and opens MySQL on all host interfaces, which can pose a security risk. If you only need localhost access for development, consider the following diff to fix indentation and restrict binding:

 services:
   db:
     image: mysql
     container_name: "db_cont"
-    ports:
-      -"3306:3306"
+    ports:
+      - "127.0.0.1:3306:3306"
     environment:
       - MYSQL_ROOT_PASSWORD=root
       - MYSQL_DATABASE=test_db

Please confirm if external access to MySQL is required; if so, document the intention or apply firewall rules to limit exposure.

🏁 Script executed:

#!/bin/bash
set -e
echo "Lines 35-50 of docker-compose.yml:"
sed -n '35,50p' docker-compose.yml

Length of output: 492

Fix YAML syntax and tighten MySQL port exposure

The ports entry in docker-compose.yml is both invalid YAML (missing a space after the dash) and exposes MySQL on all host interfaces. Unless you explicitly need remote access, bind it to localhost:

• File: docker-compose.yml
Lines: 41–42

 services:
   db:
     image: mysql
     container_name: "db_cont"
-    ports:
-      -"3306:3306"
+    ports:
+      - "127.0.0.1:3306:3306"
     environment:
       - MYSQL_ROOT_PASSWORD=root
       - MYSQL_DATABASE=test_db

Please confirm whether external access is required. If so, document your intention or enforce host-level firewall rules to limit exposure.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ports:
-"3306:3306"
services:
db:
image: mysql
container_name: "db_cont"
ports:
- "127.0.0.1:3306:3306"
environment:
- MYSQL_ROOT_PASSWORD=root
- MYSQL_DATABASE=test_db

environment:
- MYSQL_ROOT_PASSWORD=root
- MYSQL_DATABASE=test_db
Expand Down