Adding CCi to M2 #4040
Open
Adding CCi to M2 #4040
+3,130
−547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matrix internals have changed
Add factory patch
RRb and CCb will be added later and will use GC-allocated memory.
InexactNumber (w/o the apostrophe) already does. This also simplifies promotion for inexact numbers, as when the ring has Number as an ancestor, then we promote directly in the engine rather than promoting chain-wise through each of the base rings.
Member
Author
|
I don't know why the test is failing (did we break something or is something bigger broken?) Help would be appreciated. I found the change that was causing this. But, I'm not sure the best way to do this. |
d-torrance
reviewed
Nov 26, 2025
Member
Author
|
I briefly checked over the most recent changes, and I'm OK with them. I didn't see any drastic changes there (indenting and tests, only, I think). I also did a check with my local copy, and I didn't see any issues. I'm ok with merging whenever you're happy (and the review has passed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work started at the M2 conference in Madison. This is the pull request to add CCi support to M2. This includes implementations in the M2 language, the D-language, and aring support for polynomials and matrices in the back-end.