Pick whether to pre-generate files solely based on the component

Whether a component started with configuration-independent
platform-independent generated files present or not depended on the
repository and on the state of the working directory:

* In TF-PSA-Crypto, we started with whatever generated files were present
  before invoking the script, and didn't touch them between components.
* In Mbed TLS, we always started with generated files present (for
  subsequent components, only if they hadn't been messed up).

After this change, the behavior is the same across repositories and doesn't
depend on the initial state of the working directory:

* `check_xxx` components start with the generated files present. This is
  either indifferent or necessary depending on the component. (Without
  generated files, some components such as `check_names` fail, while others
  such as `check_test_cases` miss stuff that they should check.)
* Other components (`build_xxx`, `test_xxx`, etc.) start with the generated
  files absent. This is generally desirable so that we test that the build
  scripts generate them as needed.

Fix #188

Signed-off-by: Gilles Peskine <[email protected]>

Author: gilles-peskine-arm

scripts/all-core.sh

@@ -365,6 +365,9 @@ EOF
 # Does not remove generated source files.
 cleanup()
 {
+    # In Mbed TLS, we do in-tree builds, so clean up.
+    # In TF-PSA-Crypto, in-tree builds are technically possible but discouraged
+    # and not done in all.sh so we don't clean up.
     if in_mbedtls_repo; then
         command make clean
     fi
@@ -874,17 +877,6 @@ pre_check_tools () {
     "$@" "${BASH_SOURCE%/*}"/output_env.sh
 }
 
-pre_generate_files() {
-    # since make doesn't have proper dependencies, remove any possibly outdate
-    # file that might be around before generating fresh ones
-    make neat
-    if [ $QUIET -eq 1 ]; then
-        make generated_files >/dev/null
-    else
-        make generated_files
-    fi
-}
-
 pre_load_helpers () {
     # Use a path relative to the currently-sourced file.
     test_script_dir="${BASH_SOURCE%/*}"
@@ -951,6 +943,27 @@ run_component () {
         pre_create_tf_psa_crypto_out_of_source_directory
     fi
 
+    case ${current_component#component_} in
+        check_*|tf_psa_crypto_check*)
+            # Many check_xxx components expect generated files to be present,
+            # and may silently check less if they aren't.
+            if in_mbedtls_repo; then
+                make generated_files
+            else
+                $FRAMEWORK/scripts/make_generated_files.py
+            fi;;
+        *)
+            # Build (and build-and-test) components are supposed to work
+            # whether generated files are already present or not.
+            # Test with the generated files absent, since if this works,
+            # it's likely to work with generated files present as well.
+            if in_mbedtls_repo; then
+                make neat
+            else
+                $FRAMEWORK/scripts/make_generated_files.py --clean
+            fi
+    esac
+
     # Run the component in a subshell, with error trapping and output
     # redirection set up based on the relevant options.
     if [ $KEEP_GOING -eq 1 ]; then
@@ -1021,9 +1034,6 @@ main () {
     pre_print_configuration
     pre_check_tools
     cleanup
-    if in_mbedtls_repo; then
-        pre_generate_files
-    fi
 
     # Run the requested tests.
     for ((error_test_i=1; error_test_i <= error_test; error_test_i++)); do