Skip to content

Commit d455bad

Browse files
Use .s extension for assembly
Having assembly files called *.o was confusing. Signed-off-by: Gilles Peskine <[email protected]>
1 parent 9593a8c commit d455bad

File tree

1 file changed

+24
-24
lines changed

1 file changed

+24
-24
lines changed

tests/scripts/components-platform.sh

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -171,27 +171,27 @@ component_build_aes_armce () {
171171
# test for presence of AES instructions
172172
scripts/config.py set MBEDTLS_AES_USE_HARDWARE_ONLY
173173
msg "clang, test A32 crypto instructions built"
174-
make -B library/aesce.o CC=clang CFLAGS="--target=arm-linux-gnueabihf -mcpu=cortex-a72+crypto -marm -S"
175-
grep -E 'aes[0-9a-z]+.[0-9]\s*[qv]' library/aesce.o
174+
make -B library/aesce.s CC=clang CFLAGS="--target=arm-linux-gnueabihf -mcpu=cortex-a72+crypto -marm"
175+
grep -E 'aes[0-9a-z]+.[0-9]\s*[qv]' library/aesce.s
176176
msg "clang, test T32 crypto instructions built"
177-
make -B library/aesce.o CC=clang CFLAGS="--target=arm-linux-gnueabihf -mcpu=cortex-a32+crypto -mthumb -S"
178-
grep -E 'aes[0-9a-z]+.[0-9]\s*[qv]' library/aesce.o
177+
make -B library/aesce.s CC=clang CFLAGS="--target=arm-linux-gnueabihf -mcpu=cortex-a32+crypto -mthumb"
178+
grep -E 'aes[0-9a-z]+.[0-9]\s*[qv]' library/aesce.s
179179
msg "clang, test aarch64 crypto instructions built"
180-
make -B library/aesce.o CC=clang CFLAGS="--target=aarch64-linux-gnu -march=armv8-a -S"
181-
grep -E 'aes[a-z]+\s*[qv]' library/aesce.o
180+
make -B library/aesce.s CC=clang CFLAGS="--target=aarch64-linux-gnu -march=armv8-a"
181+
grep -E 'aes[a-z]+\s*[qv]' library/aesce.s
182182

183183
# test for absence of AES instructions
184184
scripts/config.py unset MBEDTLS_AES_USE_HARDWARE_ONLY
185185
scripts/config.py unset MBEDTLS_AESCE_C
186186
msg "clang, test A32 crypto instructions not built"
187-
make -B library/aesce.o CC=clang CFLAGS="--target=arm-linux-gnueabihf -mcpu=cortex-a72+crypto -marm -S"
188-
not grep -E 'aes[0-9a-z]+.[0-9]\s*[qv]' library/aesce.o
187+
make -B library/aesce.s CC=clang CFLAGS="--target=arm-linux-gnueabihf -mcpu=cortex-a72+crypto -marm"
188+
not grep -E 'aes[0-9a-z]+.[0-9]\s*[qv]' library/aesce.s
189189
msg "clang, test T32 crypto instructions not built"
190-
make -B library/aesce.o CC=clang CFLAGS="--target=arm-linux-gnueabihf -mcpu=cortex-a32+crypto -mthumb -S"
191-
not grep -E 'aes[0-9a-z]+.[0-9]\s*[qv]' library/aesce.o
190+
make -B library/aesce.s CC=clang CFLAGS="--target=arm-linux-gnueabihf -mcpu=cortex-a32+crypto -mthumb"
191+
not grep -E 'aes[0-9a-z]+.[0-9]\s*[qv]' library/aesce.s
192192
msg "clang, test aarch64 crypto instructions not built"
193-
make -B library/aesce.o CC=clang CFLAGS="--target=aarch64-linux-gnu -march=armv8-a -S"
194-
not grep -E 'aes[a-z]+\s*[qv]' library/aesce.o
193+
make -B library/aesce.s CC=clang CFLAGS="--target=aarch64-linux-gnu -march=armv8-a"
194+
not grep -E 'aes[a-z]+\s*[qv]' library/aesce.s
195195
}
196196

197197
support_build_sha_armce () {
@@ -237,32 +237,32 @@ component_build_sha_armce () {
237237
for opt in MBEDTLS_SHA256_USE_ARMV8_A_CRYPTO_ONLY MBEDTLS_SHA256_USE_ARMV8_A_CRYPTO_IF_PRESENT; do
238238
scripts/config.py set ${opt}
239239
msg "${opt} clang, test A32 crypto instructions built"
240-
make -B library/sha256.o CC=clang CFLAGS="--target=arm-linux-gnueabihf -mcpu=cortex-a72+crypto -marm -S"
241-
grep -E 'sha256[a-z0-9]+.32\s+[qv]' library/sha256.o
240+
make -B library/sha256.s CC=clang CFLAGS="--target=arm-linux-gnueabihf -mcpu=cortex-a72+crypto -marm"
241+
grep -E 'sha256[a-z0-9]+.32\s+[qv]' library/sha256.s
242242

243243
msg "${opt} clang, test T32 crypto instructions built"
244-
make -B library/sha256.o CC=clang CFLAGS="--target=arm-linux-gnueabihf -mcpu=cortex-a32+crypto -mthumb -S"
245-
grep -E 'sha256[a-z0-9]+.32\s+[qv]' library/sha256.o
244+
make -B library/sha256.s CC=clang CFLAGS="--target=arm-linux-gnueabihf -mcpu=cortex-a32+crypto -mthumb"
245+
grep -E 'sha256[a-z0-9]+.32\s+[qv]' library/sha256.s
246246

247247
msg "${opt} clang, test aarch64 crypto instructions built"
248-
make -B library/sha256.o CC=clang CFLAGS="--target=aarch64-linux-gnu -march=armv8-a -S"
249-
grep -E 'sha256[a-z0-9]+\s+[qv]' library/sha256.o
248+
make -B library/sha256.s CC=clang CFLAGS="--target=aarch64-linux-gnu -march=armv8-a"
249+
grep -E 'sha256[a-z0-9]+\s+[qv]' library/sha256.s
250250
scripts/config.py unset ${opt}
251251
done
252252

253253

254254
# examine the disassembly for absence of SHA instructions
255255
msg "clang, test A32 crypto instructions not built"
256-
make -B library/sha256.o CC=clang CFLAGS="--target=arm-linux-gnueabihf -mcpu=cortex-a72+crypto -marm -S"
257-
not grep -E 'sha256[a-z0-9]+.32\s+[qv]' library/sha256.o
256+
make -B library/sha256.s CC=clang CFLAGS="--target=arm-linux-gnueabihf -mcpu=cortex-a72+crypto -marm"
257+
not grep -E 'sha256[a-z0-9]+.32\s+[qv]' library/sha256.s
258258

259259
msg "clang, test T32 crypto instructions not built"
260-
make -B library/sha256.o CC=clang CFLAGS="--target=arm-linux-gnueabihf -mcpu=cortex-a32+crypto -mthumb -S"
261-
not grep -E 'sha256[a-z0-9]+.32\s+[qv]' library/sha256.o
260+
make -B library/sha256.s CC=clang CFLAGS="--target=arm-linux-gnueabihf -mcpu=cortex-a32+crypto -mthumb"
261+
not grep -E 'sha256[a-z0-9]+.32\s+[qv]' library/sha256.s
262262

263263
msg "clang, test aarch64 crypto instructions not built"
264-
make -B library/sha256.o CC=clang CFLAGS="--target=aarch64-linux-gnu -march=armv8-a -S"
265-
not grep -E 'sha256[a-z0-9]+\s+[qv]' library/sha256.o
264+
make -B library/sha256.s CC=clang CFLAGS="--target=aarch64-linux-gnu -march=armv8-a"
265+
not grep -E 'sha256[a-z0-9]+\s+[qv]' library/sha256.s
266266
}
267267

268268
component_test_m32_no_asm () {

0 commit comments

Comments
 (0)