Skip to content

Commit ab0250e

Browse files
benjisclowderdanjmGudahtt
authored
cherry-pick: Disable account syncing prod in v12.5.0 (#27982)
Cherry-picks #27943 ## **Description** This PR disables account syncing in prod until we have e2e tests and documentation of proper testing. There were no merge conflicts when picking these commits. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27982?quickstart=1) ## **Related issues** Fixes: #27943 ## **Manual testing steps** 1. yarn build 2. Account syncing should not occur ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: Dan J Miller <[email protected]> Co-authored-by: Mark Stacey <[email protected]>
1 parent 7954c6d commit ab0250e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

app/scripts/metamask-controller.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,7 @@ import {
155155
NotificationServicesPushController,
156156
NotificationServicesController,
157157
} from '@metamask/notification-services-controller';
158+
import { isProduction } from '../../shared/modules/environment';
158159
import { methodsRequiringNetworkSwitch } from '../../shared/constants/methods-tags';
159160

160161
///: BEGIN:ONLY_INCLUDE_IF(build-mmi)
@@ -1531,7 +1532,7 @@ export default class MetamaskController extends EventEmitter {
15311532
},
15321533
},
15331534
env: {
1534-
isAccountSyncingEnabled: isManifestV3,
1535+
isAccountSyncingEnabled: !isProduction() && isManifestV3,
15351536
},
15361537
messenger: this.controllerMessenger.getRestricted({
15371538
name: 'UserStorageController',

0 commit comments

Comments
 (0)