Skip to content

Commit c50e35a

Browse files
authored
fix: change create to add account (#37288)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR change the copy text of `Create Account` to `Add Account` <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/37288?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Updates add account button text to `Add account` ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1197?atlOrigin=eyJpIjoiMWRlOGQ3NDRjYjdmNGFiNTg2MTBjMTIyM2ZiYTI3MzUiLCJwIjoiaiJ9 ## **Manual testing steps** 1. Go to the account list 2. See that the `Add account` text ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <img width="403" height="599" alt="Screenshot 2025-10-28 at 10 25 28" src="https://github.com/user-attachments/assets/48eab79d-eb80-4c96-856c-4144060ef2ed" /> <!-- [screenshots/recordings] --> ### **After** <img width="406" height="606" alt="Screenshot 2025-10-28 at 10 24 55" src="https://github.com/user-attachments/assets/fe6d1995-a9a4-4389-a6f4-250156775910" /> <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Renames multichain account button and loading text to "Add account"/"Adding account..." and updates tests and e2e selectors accordingly. > > - **Localization**: > - Update `createMultichainAccountButton` to `"Add account"` and `createMultichainAccountButtonLoading` to `"Adding account..."` in `app/_locales/en/messages.json` and `app/_locales/en_GB/messages.json`. > - **E2E**: > - Adjust `test/e2e/page-objects/pages/account-list-page.ts` to wait for `"Add account"` in multichain state. > - **Unit Tests**: > - Update assertions in `ui/components/multichain-accounts/add-multichain-account/add-multichain-account.test.tsx` for new texts. > - Update `ui/pages/multichain-accounts/wallet-details-page/wallet-details-page.test.tsx` to expect `"Add account"`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit bd3120b. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent bc0aaeb commit c50e35a

File tree

5 files changed

+18
-18
lines changed

5 files changed

+18
-18
lines changed

app/_locales/en/messages.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/en_GB/messages.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/e2e/page-objects/pages/account-list-page.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ class AccountListPage {
229229
? [
230230
{
231231
css: this.createMultichainAccountButton,
232-
text: 'Create account',
232+
text: 'Add account',
233233
},
234234
this.multichainAccountOptionsMenuButton,
235235
]

ui/components/multichain-accounts/add-multichain-account/add-multichain-account.test.tsx

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ describe('AddMultichainAccount', () => {
3636
metamask: {
3737
localeMessages: {
3838
current: {
39-
createMultichainAccountButton: 'Create account',
40-
createMultichainAccountButtonLoading: 'Creating account...',
39+
createMultichainAccountButton: 'Add account',
40+
createMultichainAccountButtonLoading: 'Adding account...',
4141
},
4242
currentLocale: 'en',
4343
},
@@ -64,7 +64,7 @@ describe('AddMultichainAccount', () => {
6464
expect(
6565
screen.getByTestId(addMultichainAccountButtonTestId),
6666
).toBeInTheDocument();
67-
expect(screen.getByText('Create account')).toBeInTheDocument();
67+
expect(screen.getByText('Add account')).toBeInTheDocument();
6868
expect(
6969
container.querySelector(addMultichainAccountIconClass),
7070
).toBeInTheDocument();
@@ -91,7 +91,7 @@ describe('AddMultichainAccount', () => {
9191

9292
fireEvent.click(screen.getByTestId(addMultichainAccountButtonTestId));
9393

94-
expect(screen.getByText('Creating account...')).toBeInTheDocument();
94+
expect(screen.getByText('Adding account...')).toBeInTheDocument();
9595
expect(
9696
container.querySelector(addMultichainAccountIconClass),
9797
).not.toBeInTheDocument();
@@ -131,7 +131,7 @@ describe('AddMultichainAccount', () => {
131131
fireEvent.click(screen.getByTestId(addMultichainAccountButtonTestId));
132132

133133
// Verify we're in the loading state first
134-
expect(screen.getByText('Creating account...')).toBeInTheDocument();
134+
expect(screen.getByText('Adding account...')).toBeInTheDocument();
135135

136136
// Wait for the async operation to complete (first run any pending promises)
137137
await Promise.resolve();
@@ -140,7 +140,7 @@ describe('AddMultichainAccount', () => {
140140
await Promise.resolve();
141141

142142
// Check that the component returned to normal state
143-
expect(screen.getByText('Create account')).toBeInTheDocument();
143+
expect(screen.getByText('Add account')).toBeInTheDocument();
144144
expect(
145145
container.querySelector(addMultichainAccountIconClass),
146146
).toBeInTheDocument();
@@ -187,10 +187,10 @@ describe('AddMultichainAccount', () => {
187187
store,
188188
);
189189

190-
fireEvent.click(getByText('Create account'));
190+
fireEvent.click(getByText('Add account'));
191191

192192
await waitFor(() => {
193-
expect(getByText('Creating account...')).toBeInTheDocument();
193+
expect(getByText('Adding account...')).toBeInTheDocument();
194194
});
195195
});
196196

@@ -230,7 +230,7 @@ describe('AddMultichainAccount', () => {
230230
expect(getByText('Syncing...')).toBeInTheDocument();
231231
});
232232

233-
it('shows default create account text when no loading states are active', () => {
233+
it('shows default Add account text when no loading states are active', () => {
234234
mockUseAccountsOperationsLoadingStates.mockReturnValue({
235235
isAccountTreeSyncingInProgress: false,
236236
areAnyOperationsLoading: false,
@@ -242,7 +242,7 @@ describe('AddMultichainAccount', () => {
242242
store,
243243
);
244244

245-
expect(getByText('Create account')).toBeInTheDocument();
245+
expect(getByText('Add account')).toBeInTheDocument();
246246
});
247247

248248
it('handles loading state transitions correctly', () => {
@@ -259,7 +259,7 @@ describe('AddMultichainAccount', () => {
259259
store,
260260
);
261261

262-
expect(getByText('Create account')).toBeInTheDocument();
262+
expect(getByText('Add account')).toBeInTheDocument();
263263

264264
// Simulate account syncing starting
265265
mockUseAccountsOperationsLoadingStates.mockReturnValue({
@@ -281,7 +281,7 @@ describe('AddMultichainAccount', () => {
281281

282282
rerender(<AddMultichainAccount walletId={mockWalletId} />);
283283

284-
expect(getByText('Create account')).toBeInTheDocument();
284+
expect(getByText('Add account')).toBeInTheDocument();
285285
});
286286
});
287287
});

ui/pages/multichain-accounts/wallet-details-page/wallet-details-page.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,6 @@ describe('WalletDetailsPage', () => {
9191
it('renders AddMultichainAccount component for entropy wallets', () => {
9292
renderComponent();
9393

94-
expect(screen.getByText('Create account')).toBeInTheDocument();
94+
expect(screen.getByText('Add account')).toBeInTheDocument();
9595
});
9696
});

0 commit comments

Comments
 (0)