refactor(5566): fix lint & tests v4

DDDDDanica · DDDDDanica · commit ee73b248970c · 2025-12-01T03:08:17.000Z
diff --git a/lavamoat/browserify/beta/policy.json b/lavamoat/browserify/beta/policy.json
@@ -2275,7 +2275,8 @@
         "URL": true,
         "URLSearchParams": true,
         "console": true,
-        "document.defaultView": true
+        "document.defaultView": true,
+        "history": true
       }
     },
     "@rive-app/react-canvas>@rive-app/canvas": {
@@ -3785,6 +3786,11 @@
         "define": true
       }
     },
+    "history": {
+      "globals": {
+        "history": true
+      }
+    },
     "@toruslabs/eccrypto>elliptic>hmac-drbg": {
       "packages": {
         "ethers>@ethersproject/sha2>hash.js": true,
diff --git a/lavamoat/browserify/experimental/policy.json b/lavamoat/browserify/experimental/policy.json
@@ -2275,7 +2275,8 @@
         "URL": true,
         "URLSearchParams": true,
         "console": true,
-        "document.defaultView": true
+        "document.defaultView": true,
+        "history": true
       }
     },
     "@rive-app/react-canvas>@rive-app/canvas": {
@@ -3785,6 +3786,11 @@
         "define": true
       }
     },
+    "history": {
+      "globals": {
+        "history": true
+      }
+    },
     "@toruslabs/eccrypto>elliptic>hmac-drbg": {
       "packages": {
         "ethers>@ethersproject/sha2>hash.js": true,
diff --git a/lavamoat/browserify/flask/policy.json b/lavamoat/browserify/flask/policy.json
@@ -2275,7 +2275,8 @@
         "URL": true,
         "URLSearchParams": true,
         "console": true,
-        "document.defaultView": true
+        "document.defaultView": true,
+        "history": true
       }
     },
     "@rive-app/react-canvas>@rive-app/canvas": {
@@ -3785,6 +3786,11 @@
         "define": true
       }
     },
+    "history": {
+      "globals": {
+        "history": true
+      }
+    },
     "@toruslabs/eccrypto>elliptic>hmac-drbg": {
       "packages": {
         "ethers>@ethersproject/sha2>hash.js": true,
diff --git a/lavamoat/browserify/main/policy.json b/lavamoat/browserify/main/policy.json
@@ -2275,7 +2275,8 @@
         "URL": true,
         "URLSearchParams": true,
         "console": true,
-        "document.defaultView": true
+        "document.defaultView": true,
+        "history": true
       }
     },
     "@rive-app/react-canvas>@rive-app/canvas": {
@@ -3785,6 +3786,11 @@
         "define": true
       }
     },
+    "history": {
+      "globals": {
+        "history": true
+      }
+    },
     "@toruslabs/eccrypto>elliptic>hmac-drbg": {
       "packages": {
         "ethers>@ethersproject/sha2>hash.js": true,
diff --git a/lavamoat/browserify/policy-override.json b/lavamoat/browserify/policy-override.json
@@ -1,10 +1,20 @@
 {
   "resources": {
+    "history": {
+      "globals": {
+        "history": true
+      }
+    },
     "react-router-dom": {
       "globals": {
         "history": true
       }
     },
+    "react-router-dom>@remix-run/router": {
+      "globals": {
+        "history": true
+      }
+    },
     "@metamask/snaps-execution-environments": {
       "packages": {
         "@metamask/post-message-stream": true,
diff --git a/lavamoat/build-system/policy.json b/lavamoat/build-system/policy.json
@@ -1909,7 +1909,6 @@
         "chokidar>anymatch": true,
         "chokidar>braces": true,
         "chokidar>fsevents": true,
-        "tsx>fsevents": true,
         "eslint>glob-parent": true,
         "chokidar>is-binary-path": true,
         "del>is-glob": true,
@@ -3499,13 +3498,6 @@
         "gulp-watch>chokidar>fsevents>node-pre-gyp": true
       }
     },
-    "tsx>fsevents": {
-      "globals": {
-        "console.assert": true,
-        "process.platform": true
-      },
-      "native": true
-    },
     "string.prototype.matchall>es-abstract>function.prototype.name": {
       "globals": {
         "document": true
@@ -8910,4 +8902,4 @@
       }
     }
   }
-}
+}
diff --git a/lavamoat/webpack/mv2/policy-override.json b/lavamoat/webpack/mv2/policy-override.json
@@ -172,6 +172,11 @@
         "history": true
       }
     },
+    "react-router-dom>@remix-run/router": {
+      "globals": {
+        "history": true
+      }
+    },
     "@metamask/multichain-network-controller": {
       "packages": {
         "@metamask/multichain-network-controller>@metamask/keyring-api": true
diff --git a/lavamoat/webpack/mv2/policy.json b/lavamoat/webpack/mv2/policy.json
@@ -2350,7 +2350,8 @@
         "URL": true,
         "URLSearchParams": true,
         "console": true,
-        "document.defaultView": true
+        "document.defaultView": true,
+        "history": true
       }
     },
     "@rive-app/react-canvas>@rive-app/canvas": {
@@ -5042,7 +5043,7 @@
         "addEventListener": true,
         "confirm": true,
         "document": true,
-        "history.scrollRestoration": true,
+        "history": true,
         "location.href": true,
         "removeEventListener": true,
         "scrollTo": true,
@@ -6013,4 +6014,4 @@
       }
     }
   }
-}
+}
diff --git a/lavamoat/webpack/mv3/policy-override.json b/lavamoat/webpack/mv3/policy-override.json
@@ -172,6 +172,11 @@
         "history": true
       }
     },
+    "react-router-dom>@remix-run/router": {
+      "globals": {
+        "history": true
+      }
+    },
     "@metamask/multichain-network-controller": {
       "packages": {
         "@metamask/multichain-network-controller>@metamask/keyring-api": true
diff --git a/lavamoat/webpack/mv3/policy.json b/lavamoat/webpack/mv3/policy.json
@@ -1344,7 +1344,8 @@
         "URL": true,
         "URLSearchParams": true,
         "console": true,
-        "document.defaultView": true
+        "document.defaultView": true,
+        "history": true
       }
     },
     "@rive-app/react-canvas>@rive-app/canvas": {
@@ -3555,7 +3556,7 @@
         "addEventListener": true,
         "confirm": true,
         "document": true,
-        "history.scrollRestoration": true,
+        "history": true,
         "location.href": true,
         "removeEventListener": true,
         "scrollTo": true,
@@ -4373,4 +4374,4 @@
       }
     }
   }
-}
+}
diff --git a/ui/hooks/useMultichainAccountsIntroModal.test.ts b/ui/hooks/useMultichainAccountsIntroModal.test.ts
@@ -1,4 +1,4 @@
-import { renderHookWithProvider } from '../../test/lib/render-helpers';
+import { renderHookWithProvider } from '../../test/lib/render-helpers-navigate';
 import {
   useMultichainAccountsIntroModal,
   BIP44_ACCOUNTS_INTRODUCTION_VERSION,
diff --git a/ui/pages/bridge/index.tsx b/ui/pages/bridge/index.tsx
@@ -13,6 +13,7 @@ import {
   AWAITING_SIGNATURES_ROUTE,
   TRANSACTION_SHIELD_ROUTE,
 } from '../../helpers/constants/routes';
+import { toRelativeRoutePath } from '../routes/utils';
 import { resetBackgroundSwapsState } from '../../store/actions';
 import {
   ButtonIcon,
@@ -147,7 +148,7 @@ const CrossChainSwap = () => {
       <Content padding={0}>
         <Routes>
           <Route
-            path={PREPARE_SWAP_ROUTE}
+            path={toRelativeRoutePath(PREPARE_SWAP_ROUTE)}
             element={
               <>
                 <BridgeTransactionSettingsModal
@@ -163,7 +164,7 @@ const CrossChainSwap = () => {
             }
           />
           <Route
-            path={AWAITING_SIGNATURES_ROUTE}
+            path={toRelativeRoutePath(AWAITING_SIGNATURES_ROUTE)}
             element={
               <>
                 <Content>
diff --git a/ui/pages/confirmations/components/confirm/info/shared/edit-gas-icon/edit-gas-icon-button.test.tsx b/ui/pages/confirmations/components/confirm/info/shared/edit-gas-icon/edit-gas-icon-button.test.tsx
@@ -2,7 +2,7 @@ import React from 'react';
 import configureMockStore from 'redux-mock-store';
 import thunk from 'redux-thunk';
 import mockState from '../../../../../../../../test/data/mock-state.json';
-import { renderWithProvider } from '../../../../../../../../test/lib/render-helpers';
+import { renderWithProvider } from '../../../../../../../../test/lib/render-helpers-navigate';
 import { EditGasIconButton } from './edit-gas-icon-button';
 
 describe('<EditGasIconButton />', () => {
diff --git a/ui/pages/onboarding-flow/onboarding-flow.js b/ui/pages/onboarding-flow/onboarding-flow.js
diff --git a/ui/pages/remove-snap-account/remove-snap-account.test.tsx b/ui/pages/remove-snap-account/remove-snap-account.test.tsx
diff --git a/ui/pages/routes/routes.component.tsx b/ui/pages/routes/routes.component.tsx
diff --git a/ui/pages/routes/utils.js b/ui/pages/routes/utils.js
diff --git a/ui/pages/swaps/prepare-swap-page/view-quote-price-difference.test.js b/ui/pages/swaps/prepare-swap-page/view-quote-price-difference.test.js

Original file line number	Diff line number	Diff line change
`@@ -2350,7 +2350,8 @@`
`2350`	`2350`	`"URL": true,`
`2351`	`2351`	`"URLSearchParams": true,`
`2352`	`2352`	`"console": true,`
`2353`		`- "document.defaultView": true`
	`2353`	`+ "document.defaultView": true,`
	`2354`	`+ "history": true`
`2354`	`2355`	`}`
`2355`	`2356`	`},`
`2356`	`2357`	`"@rive-app/react-canvas>@rive-app/canvas": {`
`@@ -5042,7 +5043,7 @@`
`5042`	`5043`	`"addEventListener": true,`
`5043`	`5044`	`"confirm": true,`
`5044`	`5045`	`"document": true,`
`5045`		`- "history.scrollRestoration": true,`
	`5046`	`+ "history": true,`
`5046`	`5047`	`"location.href": true,`
`5047`	`5048`	`"removeEventListener": true,`
`5048`	`5049`	`"scrollTo": true,`
`@@ -6013,4 +6014,4 @@`
`6013`	`6014`	`}`
`6014`	`6015`	`}`
`6015`	`6016`	`}`
`6016`		`-}`
	`6017`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -1344,7 +1344,8 @@`
`1344`	`1344`	`"URL": true,`
`1345`	`1345`	`"URLSearchParams": true,`
`1346`	`1346`	`"console": true,`
`1347`		`- "document.defaultView": true`
	`1347`	`+ "document.defaultView": true,`
	`1348`	`+ "history": true`
`1348`	`1349`	`}`
`1349`	`1350`	`},`
`1350`	`1351`	`"@rive-app/react-canvas>@rive-app/canvas": {`
`@@ -3555,7 +3556,7 @@`
`3555`	`3556`	`"addEventListener": true,`
`3556`	`3557`	`"confirm": true,`
`3557`	`3558`	`"document": true,`
`3558`		`- "history.scrollRestoration": true,`
	`3559`	`+ "history": true,`
`3559`	`3560`	`"location.href": true,`
`3560`	`3561`	`"removeEventListener": true,`
`3561`	`3562`	`"scrollTo": true,`
`@@ -4373,4 +4374,4 @@`
`4373`	`4374`	`}`
`4374`	`4375`	`}`
`4375`	`4376`	`}`
`4376`		`-}`
	`4377`	`+}`