refactor(5566): migrate from v5 &v5-compat to react-router-dom-v6 #38330
+2,393
−4,395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dom in all test files
…gate Updated test files that require navigation functionality: - unconnected-account-alert.test.js - name.test.tsx - cancel-speedup-popover.test.js - customize-nonce.test.js - user-preferenced-currency-input.test.js - snap-ui-renderer/test-utils.tsx (and its dependent form.test.ts) - transaction-activity-log.component.test.js
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
✨ Files requiring CODEOWNER review ✨💎 @MetaMask/metamask-assets (3 files, +4 -4)
📜 @MetaMask/policy-reviewers (9 files, +110 -393)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...hain-accounts/permissions/permission-review-page/multichain-review-permissions-page.test.tsx
Outdated
Show resolved
Hide resolved
ui/components/app/network-connection-banner/network-connection-banner.test.tsx
Outdated
Show resolved
Hide resolved
DDDDDanica
force-pushed
the
refactor/5566-v6
branch
2 times, most recently
from
29b646e to
78999e5
Compare
Collaborator
Builds ready [78999e5]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
force-pushed
the
refactor/5566-v6
branch
2 times, most recently
from
72d6709 to
b37b714
Compare
Collaborator
Builds ready [b37b714]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Author
|
@metamaskbot update-policies |
DDDDDanica
force-pushed
the
refactor/5566-v6
branch
from
1fc8514 to
8357f72
Compare
Collaborator
Builds ready [8357f72]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
force-pushed
the
refactor/5566-v6
branch
from
8357f72 to
e0ef096
Compare
DDDDDanica
force-pushed
the
refactor/5566-v6
branch
from
e0ef096 to
e0d01da
Compare
Collaborator
Builds ready [254b147]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
force-pushed
the
refactor/5566-v6
branch
2 times, most recently
from
7ccc468 to
ee73b24
Compare
Contributor
Author
|
@metamaskbot update-policies |
DDDDDanica
force-pushed
the
refactor/5566-v6
branch
from
ee73b24 to
3d65598
Compare
| ...renderer(component, { wrapper: Wrapper }), | ||
| history, | ||
| }; | ||
| return render(component, { wrapper: Wrapper }); |
There was a problem hiding this comment.
Bug: Missing export for removed function causes import error
The test/jest/index.js file exports renderWithProviderAndHistory from ./rendering, but this function was removed from test/jest/rendering.js as part of this PR's migration. This will cause a JavaScript error when anything tries to import from test/jest or specifically import renderWithProviderAndHistory. The export statement in index.js needs to be updated to remove the reference to the deleted function.
Collaborator
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Collaborator
Builds ready [1ce4c35]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
force-pushed
the
refactor/5566-v6
branch
2 times, most recently
from
e9f5424 to
87347be
Compare
Collaborator
Builds ready [87347be]
UI Startup Metrics (1324 ± 104 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
force-pushed
the
refactor/5566-v6
branch
from
87347be to
62cb481
Compare
Collaborator
Builds ready [62cb481]
UI Startup Metrics (1260 ± 110 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
georgewrmarshall
previously approved these changes
Dec 1, 2025
Contributor
georgewrmarshall
left a comment
georgewrmarshall
left a comment
There was a problem hiding this comment.
🟢 Approving component-library and storybook changes on behalf of @MetaMask/design-system-engineers
Collaborator
Builds ready [b8a0521]
UI Startup Metrics (1221 ± 108 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
force-pushed
the
refactor/5566-v6
branch
from
7c6148c to
4e70d56
Compare
Collaborator
Builds ready [c50c837]
UI Startup Metrics (1290 ± 116 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate
react-router-domfromv5-compatandv5tov6.Changelog
CHANGELOG entry: null
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5567, https://github.com/MetaMask/MetaMask-planning/issues/5568, https://github.com/MetaMask/MetaMask-planning/issues/5569, https://github.com/MetaMask/MetaMask-planning/issues/5570
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Replaces all v5/v5-compat routing with react-router-dom v6, refactors routes/components to v6 APIs, updates tests/stories, policies, and dependencies.
react-router-dom-v5-compat/v5 with v6 across app (hooks,Routes/Route,Navigate,useRoutes).CompatRouter, v5 wrappers, and prop-passednavigate/location; use v6 hooks directly.toRelativeRoutePath) and v6-orientedcreateRouteWithLayout; rework rootRoutestouseRoutes.useNavigate,useLocation,useParams, and v6 route params (e.g., Asset, Confirm flows, Swaps, Permissions Connect, Onboarding, Settings, Notifications, Multichain pages).react-router-domv6; remove v5-compat usage; adjust snapshots and text expectations.preview.js: dropCompatRouter, use v6Routes/Route.react-router-dom-v5-compatto v6 (@remix-run/router) and addhistoryglobals where needed.react-router-domto^6.28.0; removereact-router-dom-v5-compat; update@remix-run/router; regenerate lockfile.Written by Cursor Bugbot for commit c50c837. This will update automatically on new commits. Configure here.