Skip to content

Commit 04f8536

Browse files
authored
Updated puppeteer to the latest version (#146)
* Updated puppeteer to the latest version * Launch puppeteer with no sandbox * Update actions/upload-artifact to v4
1 parent 193244d commit 04f8536

File tree

4 files changed

+539
-156
lines changed

4 files changed

+539
-156
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
- run: yarn build
1818
- run: yarn package
1919
- name: Archive packages
20-
uses: actions/upload-artifact@v2
20+
uses: actions/upload-artifact@v4
2121
with:
2222
name: packages
2323
path: artifacts

examples/benchmarking/compare.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ const compare = async (optionA: string, optionB: string, targetRelativePerforman
2323

2424
// Puppeteer doesn't really have a `launch` named export.
2525
// eslint-disable-next-line import/no-named-as-default-member
26-
const browser = await puppeteer.launch()
26+
const browser = await puppeteer.launch({
27+
args: ['--no-sandbox'],
28+
})
2729

2830
interface TraceEvent {
2931
name: string

examples/benchmarking/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"fs-extra": "^10.0.0",
2525
"html-webpack-plugin": "^5.3.2",
2626
"http-server": "^13.0.2",
27-
"puppeteer": "^10.4.0",
27+
"puppeteer": "^24.4.0",
2828
"ts-loader": "^9.2.5",
2929
"ts-node": "^10.3.1",
3030
"typescript": "^4.8.2",

0 commit comments

Comments
 (0)