Install and configure eslint (#282)

Author: davetsay

.webpack/webpack.common.js

@@ -1,5 +1,3 @@
-/* global __dirname module */
-
 const path = require('path');
 const packageDefinition = require('../package.json');
 const webpack = require('webpack');
@@ -100,7 +98,7 @@ const config = {
       bourbon: 'bourbon.scss',
       printj: path.join(__dirname, '..', 'node_modules/printj/dist/printj.min.js'),
       /**
-       * VISTA Paths
+       * OMM Paths
        **/
       types: path.join(__dirname, '..', 'src/types'),
       services: path.join(__dirname, '..', 'src/services'),
@@ -112,10 +110,10 @@ const config = {
   },
   plugins: [
     new webpack.DefinePlugin({
-      __VISTA_VERSION__: `'${packageDefinition.version}'`,
-      __VISTA_BUILD_DATE__: `'${new Date()}'`,
-      __VISTA_REVISION__: `'${gitRevision}'`,
-      __VISTA_BUILD_BRANCH__: `'${gitBranch}'`,
+      __OMM_VERSION__: `'${packageDefinition.version}'`,
+      __OMM_BUILD_DATE__: `'${new Date()}'`,
+      __OMM_REVISION__: `'${gitRevision}'`,
+      __OMM_BUILD_BRANCH__: `'${gitBranch}'`,
       __VUE_OPTIONS_API__: true, // enable/disable Options API support, default: true
       __VUE_PROD_DEVTOOLS__: false // enable/disable devtools support in production, default: false
     }),

.webpack/webpack.dev.js

@@ -1,5 +1,3 @@
-/* global __dirname module*/
-
 /*
 This configuration should be used for development purposes. It contains full source map, a
 devServer (which be invoked using by `npm start`), and a non-minified Vue.js distribution.

.webpack/webpack.prod.js

@@ -1,13 +1,10 @@
-/* global __dirname module */
-
 /*
 This configuration should be used for production installs.
 It is the default webpack configuration.
 */
 
 const { merge } = require('webpack-merge');
 const common = require('./webpack.common');
-const path = require('path');
 
 /** @type {import('webpack').Configuration} */
 module.exports = merge(common, {

eslint.config.js

@@ -0,0 +1,54 @@
+const globals = require('globals');
+const js = require('@eslint/js');
+const vueParser = require('vue-eslint-parser');
+const babelParser = require('@babel/eslint-parser');
+// eslint-plugin-prettier/recommended must be last in configuration
+// so that eslint-config-prettier has the opportunity to override other configs
+const prettierRecommended = require('eslint-plugin-prettier/recommended');
+
+/** @type {import('eslint').Linter.Config[]} */
+module.exports = [
+  {
+    ignores: ['**/dist/*', '**/target/*']
+  },
+  {
+    languageOptions: {
+      globals: {
+        ...globals.browser,
+        ...globals.es2024,
+        ...globals.jasmine,
+        ...globals.amd,
+        ...globals.node,
+        __OMM_VERSION__: 'readonly',
+        __OMM_BUILD_DATE__: 'readonly',
+        __OMM_REVISION__: 'readonly',
+        __OMM_BUILD_BRANCH__: 'readonly'
+      },
+      parser: vueParser,
+      parserOptions: {
+        parser: babelParser,
+        requireConfigFile: false,
+        allowImportExportEverywhere: true,
+        ecmaVersion: 'latest',
+        ecmaFeatures: {
+          impliedStrict: true
+        },
+        sourceType: 'module'
+      }
+    }
+  },
+  js.configs.recommended,
+  prettierRecommended,
+  {
+    rules: {
+      'no-unused-vars': [
+        'error',
+        {
+          vars: 'all',
+          args: 'none'
+        }
+      ],
+      'prettier/prettier': 'error'
+    }
+  }
+];

karma.conf.js

@@ -1,5 +1,3 @@
-/*global module*/
-
 const path = require('path');
 
 module.exports = function (config) {
@@ -13,7 +11,6 @@ module.exports = function (config) {
     use: {
       loader: 'babel-loader',
       options: {
-        // eslint-disable-next-line no-undef
         configFile: path.resolve(process.cwd(), 'babel.coverage.js')
       }
     }

loader.js

@@ -141,10 +141,10 @@ define([
    */
   function insertBuildInfo(markup) {
     return markup
-      .replace(/\$\{project\.version\}/g, __VISTA_VERSION__)
-      .replace(/\$\{timestamp\}/g, __VISTA_BUILD_DATE__)
-      .replace(/\$\{buildNumber\}/g, __VISTA_REVISION__)
-      .replace(/\$\{branch\}/g, __VISTA_BUILD_BRANCH__);
+      .replace(/\$\{project\.version\}/g, __OMM_VERSION__)
+      .replace(/\$\{timestamp\}/g, __OMM_BUILD_DATE__)
+      .replace(/\$\{buildNumber\}/g, __OMM_REVISION__)
+      .replace(/\$\{branch\}/g, __OMM_BUILD_BRANCH__);
   }
 
   return loader;

package.json

@@ -3,17 +3,24 @@
   "version": "2512.01-next",
   "description": "Open MCT for MCWS",
   "devDependencies": {
+    "@babel/eslint-parser": "7.26.8",
     "@braintree/sanitize-url": "6.0.4",
+    "@eslint/js": "9.19.0",
     "@vue/compiler-sfc": "3.4.3",
     "babel-loader": "8.2.0",
     "babel-plugin-istanbul": "6.1.1",
     "bower": "^1.7.7",
     "comma-separated-values": "3.6.4",
     "copy-webpack-plugin": "12.0.2",
     "css-loader": "6.10.0",
+    "eslint": "9.19.0",
+    "eslint-config-prettier": "10.0.1",
+    "eslint-plugin-prettier": "5.2.3",
+    "eslint-plugin-vue": "9.32.0",
     "eventemitter3": "5.0.1",
     "file-saver": "2.0.5",
     "git-rev-sync": "3.0.2",
+    "globals": "15.14.0",
     "html2canvas": "1.4.1",
     "imports-loader": "0.8.0",
     "jasmine-core": "5.1.1",
@@ -42,6 +49,7 @@
     "source-map-loader": "^0.2.4",
     "style-loader": "3.3.3",
     "vue": "3.4.24",
+    "vue-eslint-parser": "^9.4.3",
     "vue-loader": "16.8.3",
     "webpack": "5.94.0",
     "webpack-cli": "5.1.1",
@@ -51,8 +59,8 @@
   "scripts": {
     "clean": "npm cache clean --force;rm -rf ./dist ./node_modules ./target ./package-lock.json",
     "start": "npx webpack serve --config ./.webpack/webpack.dev.js",
-    "lint": "npx prettier --check \"**\"",
-    "lint:fix": "npx prettier --write \"**\"",
+    "lint": "eslint \"**\"",
+    "lint:fix": "eslint \"**\" --fix",
     "build:prod": "webpack --config ./.webpack/webpack.prod.js",
     "build:dev": "webpack --config ./.webpack/webpack.dev.js",
     "build:watch": "webpack --config ./.webpack/webpack.dev.js --watch",
@@ -72,4 +80,4 @@
   },
   "author": "",
   "license": "Apache-2.0"
-}
+}

scripts/summarize-report.js

@@ -296,7 +296,6 @@ if (!args['exclude-requirements-matrix']) {
   console.log('Requirement ID | Test Procedures | Status');
   console.log('--- | --- | --- ');
   _.each(sortedRequirements, function (requirement) {
-    var procedureCount = requirement.procedures.length;
     var implemented = _.filter(requirement.procedures, { implemented: true }).length;
     var conducted = _.filter(requirement.procedures, { conducted: true }).length;
     var verified = _.filter(requirement.procedures, { conducted: true, passed: true }).length;

src/AMMOSPlugins.js

@@ -87,7 +87,7 @@ define([
         options: timePlugin,
         format: utcFormat
       });
-      openmct.install(RealtimeIndicatorPlugin.default(vistaTime));
+      openmct.install(RealtimeIndicatorPlugin.default(vistaTime, utcFormat));
 
       mcwsClient.default.configure(options);
 

src/actionModifiers/ImportExportWithDatasets/importWithDatasetsModifier.js

@@ -98,6 +98,7 @@ function importWithDatasetsModifier(openmct) {
     try {
       json = JSON.parse(objectTree);
     } catch (error) {
+      console.error('Error parsing object tree.', error);
       success = false;
     }
 
@@ -115,6 +116,7 @@ function importWithDatasetsModifier(openmct) {
 
         component.updateData(referencedDatasets, datasets);
       } catch (error) {
+        console.error('Error updating referenced datasets.', error);
         success = false;
       }
     }
@@ -158,7 +160,7 @@ function importWithDatasetsModifier(openmct) {
         };
         const componentOptions = { element };
 
-        const { componentInstance, destroy, el } = mount(componentDefinition, componentOptions);
+        const { componentInstance, destroy } = mount(componentDefinition, componentOptions);
 
         component = componentInstance;