address PR comments

Author: jvigliotta

config.js

@@ -184,10 +184,12 @@
             lmstEpoch: Date.UTC(2020, 2, 18, 0, 0, 0),
 
             /*
-             * connectionBatchingDelay: delay in milliseconds for batching filters for the same 
-             * endpoint connection
+             * subscriptionMCWSFilterDelay: delay in milliseconds for batching filters for the same 
+             * endpoint connection. Smaller value = quicker display of realtime data (ex, 10ms in a
+             *  low latency environment), higher value = more efficient use of network bandwidth 
+             * (ex, 100ms+ in a high latency environment)
             */
-            connectionBatchingDelay: 100,
+            subscriptionMCWSFilterDelay: 100,
 
             /**
              * timeSystems: specify the time systems to use.

src/realtime/MCWSDataProductStreamProvider.js

@@ -5,11 +5,6 @@ import MCWSStreamProvider from './MCWSStreamProvider';
  * @memberof {vista/telemetry}
  */
 class MCWSDataProductStreamProvider extends MCWSStreamProvider {
-    constructor(openmct, vistaTime, options) {
-        super(openmct, vistaTime, options);
-        this.options = options;
-    }
-
     getUrl(domainObject) {
         return domainObject.telemetry?.dataProductStreamUrl;
     }

src/realtime/MCWSStreamProvider.js

@@ -21,14 +21,15 @@ class MCWSStreamProvider {
         this.vistaTime = function () {
             return vistaTime;
         };
+        this.options = options;
 
         this.sessions = sessionService();
         this.filterService = filterService();
 
         this.subscriptions = {};
         this.requests = {};
 
-        this.connectionBatchingDelay = options.time.connectionBatchingDelay || 100;
+        this.subscriptionMCWSFilterDelay = options.time?.subscriptionMCWSFilterDelay ?? 100;
     }
 
     processGlobalStaleness(data, latestTimestamp) {
@@ -92,9 +93,6 @@ class MCWSStreamProvider {
             return worker;
         }
 
-        // send connectionBatchingDelay to worker
-        this.notifyWorker('connectionBatchingDelay', this.connectionBatchingDelay);
-
         // topic
         const updateTopic = function (newValue) {
             this.notifyWorker('topic', newValue);

src/realtime/MCWSStreamWorkerScript.js

@@ -27,14 +27,14 @@
      * @param {Object} extraFilterTerms additional filter terms
      * @param {Object} globalFilters global filters to apply
      */
-    constructor(url, property, topic, extraFilterTerms, globalFilters) {
+    constructor(url, property, topic, extraFilterTerms, globalFilters, subscriptionMCWSFilterDelay) {
       this.url = url;
       this.topic = topic;
       this.subscribers = {};
       this.property = property;
       this.extraFilterTerms = extraFilterTerms;
       this.globalFilters = globalFilters;
-      this.connectionBatchingDelay = 100;
+      this.subscriptionMCWSFilterDelay = subscriptionMCWSFilterDelay ?? 100;
     }
 
     /**
@@ -141,7 +141,7 @@
       this.pending = setTimeout(() => {
         this.pending = undefined;
         this.reconnect();
-      }, this.connectionBatchingDelay);
+      }, this.subscriptionMCWSFilterDelay);
     }
 
     /**
@@ -238,7 +238,7 @@
   class MCWSStreamWorker {
     constructor() {
       this.connections = {};
-      this.batchingDelay = 100; // Initialize with default value
+      this.subscriptionMCWSFilterDelay = 100; // Initialize with default value
     }
 
     /**
@@ -256,7 +256,7 @@
           this.activeTopic,
           extraFilterTerms,
           this.activeGlobalFilters,
-          this.batchingDelay
+          this.subscriptionMCWSFilterDelay
         );
       }
 
@@ -290,15 +290,6 @@
       }
     }
 
-    /**
-     * Set the connection batching delay for all connections
-     * This should be called before any subscriptions are created
-     * @param {Number} delay in milliseconds
-     */
-    connectionBatchingDelay(delay) {
-      this.batchingDelay = delay; // Store the delay for future connections
-    }
-
     /**
      * Change the current topic selection.
      * @param {Object} topic metadata about the selected topic