Skip to content

Commit 25498f3

Browse files
liziyu179NSDie
authored andcommitted
[P/D] force with_prefill true after allreduce in kv producer (vllm-project#3768)
### What this PR does / why we need it? force with_prefill true after allreduce in kv producer - vLLM version: v0.11.0rc3 - vLLM main: vllm-project/vllm@c9461e0 --------- Signed-off-by: liziyu <[email protected]> Signed-off-by: nsdie <[email protected]>
1 parent 64b5dc3 commit 25498f3

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

vllm_ascend/distributed/mooncake_layerwise_connector.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1151,7 +1151,7 @@ def save_kv_layer(self, layer_name: str, kv_layer: Tuple[torch.Tensor,
11511151
connector_metadata: MooncakeLayerwiseConnectorMetadata,
11521152
**kwargs) -> None:
11531153
"""MooncakeLayerwiseConnector does not save explicitly."""
1154-
if self.kv_role == 'kv_producer':
1154+
if self.kv_role == 'kv_producer' and connector_metadata.request.keys():
11551155
if self.pd_head_ratio != 1:
11561156
if self.current_layer != 0:
11571157
self.completion_event.wait()

vllm_ascend/worker/model_runner_v1.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2645,6 +2645,10 @@ def _dummy_run(
26452645
tp_size = self.vllm_config.parallel_config.tensor_parallel_size
26462646
num_tokens = math.ceil(num_tokens / tp_size) * tp_size
26472647

2648+
# Force dummy run on prefill stage when this node is deemed as kv producer.
2649+
if self.is_kv_producer and not self.is_kv_consumer:
2650+
with_prefill = True
2651+
26482652
# Padding for DP
26492653
(num_tokens, num_tokens_across_dp,
26502654
with_prefill) = self._sync_metadata_across_dp(num_tokens,
@@ -2693,10 +2697,6 @@ def _dummy_run(
26932697
num_scheduled_tokens = np.array(num_scheduled_tokens_list,
26942698
dtype=np.int32)
26952699

2696-
# Force dummy run on prefill stage when this node is deemed as kv producer.
2697-
if self.is_kv_producer and not self.is_kv_consumer:
2698-
with_prefill = True
2699-
27002700
if not self.in_profile_run and self.dynamic_eplb:
27012701
self.eplb_updator.forward_before()
27022702

0 commit comments

Comments
 (0)