Skip to content

Commit 447a15d

Browse files
clean up comments
Signed-off-by: Daniel Korzekwa <[email protected]>
1 parent f5baed2 commit 447a15d

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

modelopt/torch/nas/plugins/megatron.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -594,7 +594,6 @@ def _setup(self):
594594
max_size = num_heads_per_group_max * num_query_groups_max * self.config.kv_channels
595595
activation_hook = MegatronL2NormHook(max_size=max_size)
596596
self._register_temp_attribute("_activation_hook", activation_hook)
597-
# TODO: confusion: why hook_handle is removed manually in export() and not using _register_temp_attribute?
598597
self.hook_handle = self.linear_proj.register_forward_hook(activation_hook)
599598
# NOTE: num_heads_per_group's slice_order will be of length num_attention_heads to be able to sort heads,
600599
# otherwise we would only have aggregated importance of heads per group.

0 commit comments

Comments
 (0)