Skip to content

Commit f6604f9

Browse files
Migrate onnx_ptq bash tests to github as well
Signed-off-by: Keval Morabia <[email protected]>
1 parent 1bb63a4 commit f6604f9

File tree

3 files changed

+26
-30
lines changed

3 files changed

+26
-30
lines changed

.github/workflows/_example_tests_runner.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@ on:
2727
required: false
2828
type: string
2929
default: "linux-amd64-gpu-h100-latest-1"
30+
test_type:
31+
description: "Test type: 'pytest' or 'bash'"
32+
required: false
33+
type: string
34+
default: "pytest"
3035

3136
jobs:
3237
run-test:
@@ -60,5 +65,8 @@ jobs:
6065
find examples/${{ inputs.example }} -name "requirements.txt" | while read req_file; do pip install -r "$req_file" || exit 1; done
6166
- name: Run tests
6267
run: |
63-
echo "Running tests for: ${{ inputs.example }}"
64-
pytest tests/examples/${{ inputs.example }}
68+
if [ "${{ inputs.test_type }}" = "bash" ]; then
69+
bash tests/examples/test_${{ inputs.example }}.sh
70+
else
71+
pytest tests/examples/${{ inputs.example }}
72+
fi

.github/workflows/example_tests.yml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,22 @@ jobs:
140140
pip_install_extras: "[all,dev-test]"
141141
runner: linux-amd64-gpu-l4-latest-1
142142

143+
# TODO: convert test to pytest as well so we can remove this job
144+
example-onnx-bash-non-pr:
145+
if: ${{ !startsWith(github.ref, 'refs/heads/pull-request/') }}
146+
strategy:
147+
matrix:
148+
example: [onnx_ptq]
149+
uses: ./.github/workflows/_example_tests_runner.yml
150+
secrets: inherit
151+
with:
152+
docker_image: "nvcr.io/nvidia/tensorrt:25.08-py3"
153+
example: ${{ matrix.example }}
154+
timeout_minutes: 90
155+
pip_install_extras: "[all,dev-test]"
156+
runner: linux-amd64-gpu-l4-latest-1
157+
test_type: bash
158+
143159
##### Required Check for PR #####
144160
example-pr-required-check:
145161
# Run even if example tests are skipped

.gitlab/tests.yml

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,3 @@
1-
# NOTE: Make sure this file is consistent with .github/workflows/{unit,gpu,example}_tests.yml
2-
.tests-default:
3-
variables:
4-
PIP_CONSTRAINT: "" # Disable pip constraint for upgrading packages
5-
stage: tests
6-
rules:
7-
- if: $CI_PIPELINE_SOURCE == "schedule"
8-
- if: $CI_COMMIT_TAG =~ /^\d+\.\d+\.\d+$/
9-
- if: $CI_PIPELINE_SOURCE == "web" || $CI_MERGE_REQUEST_TARGET_BRANCH_PROTECTED == "true"
10-
when: manual
11-
12-
##### Example Tests #####
13-
example-onnx-bash:
14-
extends: .tests-default
15-
timeout: 90m
16-
image: nvcr.io/nvidia/tensorrt:25.08-py3
17-
tags: [docker, linux, 2-gpu, sm>=89]
18-
parallel:
19-
matrix:
20-
- EXAMPLE: [onnx_ptq]
21-
before_script:
22-
# Add libcudnn*.so and libnv*.so to path
23-
- export LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:/usr/include:/usr/lib/x86_64-linux-gnu"
24-
script:
25-
- pip install ".[all,dev-test]"
26-
- find examples/$EXAMPLE -name "requirements.txt" | while read req_file; do pip install -r "$req_file" || exit 1; done
27-
- bash tests/examples/test_$EXAMPLE.sh
28-
291
##### Megatron / NeMo Integration Tests #####
302
megatron-nemo-integration:
313
extends: .tests-default

0 commit comments

Comments
 (0)