Remove warmup_iterations and iterations arguments for nds-h #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jihoon Son <[email protected]>
jihoonson
force-pushed
the
revert-iterations-nds-h
branch
from
0f1472b to
55636bc
Compare
pxLi
previously approved these changes
Mar 14, 2025
Member
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #204.
The issue is that the
PysparkBenchReportclassnds_h_power.pyuses isutil/python_benchmark_reporter/PysparkBenchReport.py, whereas thePysparkBenchReportclass modified in #202 isnds/PysparkBenchReport.py. As the former was not modified to support new arguments, the nds_h script fails. I rather reverted my change for nds-h in this PR than fixing theutil/python_benchmark_reporter/PysparkBenchReport.pyfile. It seems strange to have duplicate classes, one for nds and another for nds-h. We should just consolidate them.