Fix q78 problematic value comparison #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yinqing Hao <[email protected]>
Signed-off-by: Yinqing Hao <[email protected]>
mattahrens
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue with the q78 problematic value comparison in the nds_validate.py file by refining the condition checks and updating the license year.
- Updated license year from 2023 to 2025.
- Improved comparison logic by explicitly checking for None instead of relying on truthiness.
- Refactored the conditional that ensures both problematic values are either comparable or both None.
Comments suppressed due to low confidence (1)
nds/nds_validate.py:185
- [nitpick] Consider defining the tolerance value 0.01001 as a named constant for improved clarity and easier maintenance.
problematic_val_eq = abs(problematic_val_row1 - problematic_val_row2) <= 0.01001
pxLi
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix: #209
Verified in CI test job.