Skip to content

Commit a063679

Browse files
authored
adjust spectator-go testing advice
1 parent d4d5c82 commit a063679

File tree

1 file changed

+21
-8
lines changed

1 file changed

+21
-8
lines changed

docs/spectator/lang/go/usage.md

Lines changed: 21 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -241,21 +241,24 @@ which stores all updates in an `Array`. Maintain a handle to the `MemoryWriter`,
241241
import (
242242
"fmt"
243243
"github.com/Netflix/spectator-go/v2/spectator"
244+
"github.com/Netflix/spectator-go/v2/spectator/logger"
244245
"github.com/Netflix/spectator-go/v2/spectator/writer"
245246
"testing"
246247
"time"
247248
)
248249

249250
func TestRegistryWithMemoryWriter_Counter(t *testing.T) {
250-
config, _ := spectator.NewConfig("memory", nil, nil)
251+
config, _ := spectator.NewConfig("memory", nil, logger.NewDefaultLogger())
251252
registry, _ = spectator.NewRegistry(config)
252253
mw := registry.GetWriter().(*writer.MemoryWriter)
253254

254255
counter := registry.Counter("test_counter", nil)
255256
counter.Increment()
256257

257-
assert.Len(t, mw.Lines(), 1)
258-
assert.EqualValues(t, "c:test_counter:1", mw.Lines()[0])
258+
expected := "c:test_counter:1"
259+
if len(mw.Lines()) != 1 || mw.Lines()[0] != expected {
260+
t.Errorf("Expected '%s', got '%s'", expected, mw.Lines()[0])
261+
}
259262
}
260263
```
261264

@@ -274,11 +277,21 @@ func TestParseProtocolLineWithValidInput(t *testing.T) {
274277
line := "c:name,tag1=value1,tag2=value2:50"
275278
meterType, meterId, value, err := spectator.ParseProtocolLine(line)
276279

277-
assert.NoError(t, err)
278-
assert.EqualValues(t, "c", meterType)
279-
assert.EqualValues(t, "name", meterId.Name())
280-
assert.EqualValues(t, map[string]string{"tag1": "value1", "tag2": "value2"}, meterId.Tags())
281-
assert.EqualValues(t, "50", value)
280+
if err != nil {
281+
t.Errorf("Unexpected error: %v", err)
282+
}
283+
284+
if meterType != "c" {
285+
t.Errorf("Unexpected meter type: %v", meterType)
286+
}
287+
288+
if meterId.Name() != "name" || meterId.Tags()["tag1"] != "value1" || meterId.Tags()["tag2"] != "value2" {
289+
t.Errorf("Unexpected meter id: %v", meterId)
290+
}
291+
292+
if value != "50" {
293+
t.Errorf("Unexpected value: %v", value)
294+
}
282295
}
283296
```
284297

0 commit comments

Comments
 (0)