Skip to content

Commit 1c9b8f5

Browse files
Merge pull request #839 from Netflix/fix/revert-max-projection-depth-cleanup
Revert "remove obsolete maxProjectionDepth #826"
2 parents daeb80a + f7b4ae5 commit 1c9b8f5

File tree

3 files changed

+14
-0
lines changed

3 files changed

+14
-0
lines changed

graphql-dgs-codegen-core/src/main/kotlin/com/netflix/graphql/dgs/codegen/CodeGen.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -543,6 +543,7 @@ class CodeGenConfig(
543543
var shortProjectionNames: Boolean = false,
544544
var generateDataTypes: Boolean = true,
545545
var omitNullInputFields: Boolean = false,
546+
var maxProjectionDepth: Int = 10,
546547
var kotlinAllFieldsOptional: Boolean = false,
547548
/** If enabled, the names of the classes available via the DgsConstant class will be snake cased.*/
548549
var snakeCaseConstantNames: Boolean = false,

graphql-dgs-codegen-core/src/test/kotlin/com/netflix/graphql/dgs/codegen/clientapi/ClientApiGenBuilderTest.kt

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ class ClientApiGenBuilderTest {
4040
schemas = setOf(schema),
4141
packageName = BASE_PACKAGE_NAME,
4242
generateClientApiv2 = true,
43+
maxProjectionDepth = 2,
4344
),
4445
).generate()
4546

@@ -74,6 +75,7 @@ class ClientApiGenBuilderTest {
7475
schemas = setOf(schema),
7576
packageName = BASE_PACKAGE_NAME,
7677
generateClientApiv2 = true,
78+
maxProjectionDepth = 2,
7779
),
7880
).generate()
7981

@@ -105,6 +107,7 @@ class ClientApiGenBuilderTest {
105107
schemas = setOf(schema),
106108
packageName = BASE_PACKAGE_NAME,
107109
generateClientApiv2 = true,
110+
maxProjectionDepth = 2,
108111
),
109112
).generate()
110113

@@ -134,6 +137,7 @@ class ClientApiGenBuilderTest {
134137
schemas = setOf(schema),
135138
packageName = BASE_PACKAGE_NAME,
136139
generateClientApiv2 = true,
140+
maxProjectionDepth = 2,
137141
),
138142
).generate()
139143

@@ -172,6 +176,7 @@ class ClientApiGenBuilderTest {
172176
schemas = setOf(schema),
173177
packageName = BASE_PACKAGE_NAME,
174178
generateClientApiv2 = true,
179+
maxProjectionDepth = 2,
175180
addDeprecatedAnnotation = true,
176181
),
177182
).generate()
@@ -217,6 +222,7 @@ class ClientApiGenBuilderTest {
217222
schemas = setOf(schema),
218223
packageName = BASE_PACKAGE_NAME,
219224
generateClientApiv2 = true,
225+
maxProjectionDepth = 2,
220226
addDeprecatedAnnotation = true,
221227
),
222228
).generate()
@@ -268,6 +274,7 @@ class ClientApiGenBuilderTest {
268274
schemas = setOf(schema),
269275
packageName = BASE_PACKAGE_NAME,
270276
generateClientApiv2 = true,
277+
maxProjectionDepth = 2,
271278
addDeprecatedAnnotation = true,
272279
),
273280
).generate()
@@ -321,6 +328,7 @@ class ClientApiGenBuilderTest {
321328
schemas = setOf(schema),
322329
packageName = BASE_PACKAGE_NAME,
323330
generateClientApiv2 = true,
331+
maxProjectionDepth = 2,
324332
addDeprecatedAnnotation = true,
325333
),
326334
).generate()
@@ -376,6 +384,7 @@ class ClientApiGenBuilderTest {
376384
schemas = setOf(schema),
377385
packageName = BASE_PACKAGE_NAME,
378386
generateClientApiv2 = true,
387+
maxProjectionDepth = 2,
379388
),
380389
).generate()
381390

graphql-dgs-codegen-gradle/src/main/kotlin/com/netflix/graphql/dgs/codegen/gradle/GenerateJavaTask.kt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,9 @@ open class GenerateJavaTask
134134
@Input
135135
var omitNullInputFields = false
136136

137+
@Input
138+
var maxProjectionDepth = 10
139+
137140
@Input
138141
var kotlinAllFieldsOptional = false
139142

@@ -213,6 +216,7 @@ open class GenerateJavaTask
213216
shortProjectionNames = shortProjectionNames,
214217
generateDataTypes = generateDataTypes,
215218
omitNullInputFields = omitNullInputFields,
219+
maxProjectionDepth = maxProjectionDepth,
216220
kotlinAllFieldsOptional = kotlinAllFieldsOptional,
217221
snakeCaseConstantNames = snakeCaseConstantNames,
218222
implementSerializable = implementSerializable,

0 commit comments

Comments
 (0)