Automatically disable parameterized constructor for large types with >255 fields (#817)

jjacobs44 · web-flow · commit 286c6b117177 · 2025-04-08T16:09:02.000-07:00
diff --git a/graphql-dgs-codegen-core/src/main/kotlin/com/netflix/graphql/dgs/codegen/generators/java/DataTypeGenerator.kt b/graphql-dgs-codegen-core/src/main/kotlin/com/netflix/graphql/dgs/codegen/generators/java/DataTypeGenerator.kt
@@ -393,7 +393,7 @@ abstract class BaseDataTypeGenerator(
 
         addDefaultConstructor(javaType)
 
-        if (config.javaGenerateAllConstructor && fields.isNotEmpty()) {
+        if (config.javaGenerateAllConstructor && fields.isNotEmpty() && fields.size < 256) {
             addParameterizedConstructor(fields, javaType)
         }
 
diff --git a/graphql-dgs-codegen-gradle/src/test/resources/test-project/build.gradle b/graphql-dgs-codegen-gradle/src/test/resources/test-project/build.gradle
@@ -32,7 +32,6 @@ generateJava {
     generatedSourcesDir = "${projectDir}/build/graphql"
     typeMapping = [Date:"java.time.LocalDateTime"]
     generateDocs = true
-    javaGenerateAllConstructor = false
 }
 
 codegen.clientCoreConventionsEnabled = false
diff --git a/graphql-dgs-codegen-gradle/src/test/resources/test-project/build_omit_null_input_fields.gradle b/graphql-dgs-codegen-gradle/src/test/resources/test-project/build_omit_null_input_fields.gradle
@@ -34,7 +34,6 @@ generateJava {
     generateClient = true
     generateDataTypes = true
     generateDocs = true
-    javaGenerateAllConstructor = false
 }
 
 codegen.clientCoreConventionsEnabled = false
diff --git a/graphql-dgs-codegen-gradle/src/test/resources/test-project/build_with_default_dir.gradle b/graphql-dgs-codegen-gradle/src/test/resources/test-project/build_with_default_dir.gradle
@@ -30,7 +30,6 @@ generateJava {
     schemaPaths = ["${projectDir}/src/main/resources/schema"]
     packageName = 'com.netflix.testproject.graphql'
     typeMapping = [Date:"java.time.LocalDateTime"]
-    javaGenerateAllConstructor = false
     // no generated sources dir specified
 }
 

Original file line number	Diff line number	Diff line change
`@@ -393,7 +393,7 @@ abstract class BaseDataTypeGenerator(`
`393`	`393`
`394`	`394`	`addDefaultConstructor(javaType)`
`395`	`395`
`396`		`- if (config.javaGenerateAllConstructor && fields.isNotEmpty()) {`
	`396`	`+ if (config.javaGenerateAllConstructor && fields.isNotEmpty() && fields.size < 256) {`
`397`	`397`	`addParameterizedConstructor(fields, javaType)`
`398`	`398`	`}`
`399`	`399`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,6 @@ generateJava {`
`32`	`32`	`generatedSourcesDir = "${projectDir}/build/graphql"`
`33`	`33`	`typeMapping = [Date:"java.time.LocalDateTime"]`
`34`	`34`	`generateDocs = true`
`35`		`- javaGenerateAllConstructor = false`
`36`	`35`	`}`
`37`	`36`
`38`	`37`	`codegen.clientCoreConventionsEnabled = false`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,6 @@ generateJava {`
`34`	`34`	`generateClient = true`
`35`	`35`	`generateDataTypes = true`
`36`	`36`	`generateDocs = true`
`37`		`- javaGenerateAllConstructor = false`
`38`	`37`	`}`
`39`	`38`
`40`	`39`	`codegen.clientCoreConventionsEnabled = false`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,6 @@ generateJava {`
`30`	`30`	`schemaPaths = ["${projectDir}/src/main/resources/schema"]`
`31`	`31`	`packageName = 'com.netflix.testproject.graphql'`
`32`	`32`	`typeMapping = [Date:"java.time.LocalDateTime"]`
`33`		`- javaGenerateAllConstructor = false`
`34`	`33`	`// no generated sources dir specified`
`35`	`34`	`}`
`36`	`35`