Merge pull request #1601 from spencergibb/2.x-remove-exceptionutils-usage

Removes usage of ExceptionUtils

Author: howardyuan

eureka-client/src/main/java/com/netflix/discovery/DiscoveryClient.java

@@ -59,7 +59,6 @@
 
 import com.netflix.discovery.shared.resolver.EndpointRandomizer;
 import com.netflix.discovery.shared.resolver.ResolverUtils;
-import org.apache.commons.lang.exception.ExceptionUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -812,8 +811,8 @@ public Applications getApplications(String serviceUrl) {
             logger.info(PREFIX + "{} - was unable to refresh its cache! This periodic background refresh will be retried in {} seconds. status = {}",
                     appPathIdentifier, clientConfig.getRegistryFetchIntervalSeconds(), response.getStatusCode());
         } catch (Throwable th) {
-            logger.info(PREFIX + "{} - was unable to refresh its cache! This periodic background refresh will be retried in {} seconds. status = {} stacktrace = {}",
-                    appPathIdentifier, clientConfig.getRegistryFetchIntervalSeconds(), th.getMessage(), ExceptionUtils.getStackTrace(th));
+            logger.info(String.format(PREFIX + "%s - was unable to refresh its cache! This periodic background refresh will be retried in %d seconds. status = %s",
+                    appPathIdentifier, clientConfig.getRegistryFetchIntervalSeconds(), th.getMessage()), th);
         }
         return null;
     }
@@ -965,8 +964,8 @@ private boolean fetchRegistry(boolean forceFullRegistryFetch) {
             applications.setAppsHashCode(applications.getReconcileHashCode());
             logTotalInstances();
         } catch (Throwable e) {
-            logger.info(PREFIX + "{} - was unable to refresh its cache! This periodic background refresh will be retried in {} seconds. status = {} stacktrace = {}",
-                    appPathIdentifier, clientConfig.getRegistryFetchIntervalSeconds(), e.getMessage(), ExceptionUtils.getStackTrace(e));
+            logger.info(String.format(PREFIX + "%s - was unable to refresh its cache! This periodic background refresh will be retried in %d seconds. status = %s",
+                    appPathIdentifier, clientConfig.getRegistryFetchIntervalSeconds(), e.getMessage()), e);
             return false;
         } finally {
             SpectatorUtil.record(FETCH_REGISTRY_TIMER, monotonicTime);

eureka-client/src/main/java/com/netflix/discovery/shared/transport/decorator/RedirectingEurekaHttpClient.java

@@ -31,7 +31,6 @@
 import com.netflix.discovery.shared.transport.TransportClientFactory;
 import com.netflix.discovery.shared.transport.TransportException;
 import com.netflix.discovery.shared.transport.TransportUtils;
-import org.apache.commons.lang.exception.ExceptionUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -81,17 +80,17 @@ protected <R> EurekaHttpResponse<R> execute(RequestExecutor<R> requestExecutor)
                 TransportUtils.shutdown(delegateRef.getAndSet(currentEurekaClientRef.get()));
                 return response;
             } catch (Exception e) {
-                logger.info("Request execution error. endpoint={}, exception={} stacktrace={}", serviceEndpoint,
-                        e.getMessage(), ExceptionUtils.getStackTrace(e));
+                logger.info(String.format("Request execution error. endpoint=%s, exception=%s", serviceEndpoint,
+                        e.getMessage()), e);
                 TransportUtils.shutdown(currentEurekaClientRef.get());
                 throw e;
             }
         } else {
             try {
                 return requestExecutor.execute(currentEurekaClient);
             } catch (Exception e) {
-                logger.info("Request execution error. endpoint={} exception={} stacktrace={}", serviceEndpoint,
-                        e.getMessage(), ExceptionUtils.getStackTrace(e));
+                logger.info(String.format("Request execution error. endpoint=%s exception=%s", serviceEndpoint,
+                        e.getMessage()), e);
                 delegateRef.compareAndSet(currentEurekaClient, null);
                 currentEurekaClient.shutdown();
                 throw e;